Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: components/arc/ime/arc_ime_bridge_impl.cc

Issue 2876693004: Implement GetTextFromRange(), GetTextRange() and GetSelectionRange() for ArcImeService. (Closed)
Patch Set: add TODOs in ime.mojom Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/ime/arc_ime_bridge_impl.h ('k') | components/arc/ime/arc_ime_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/ime/arc_ime_bridge_impl.cc
diff --git a/components/arc/ime/arc_ime_bridge_impl.cc b/components/arc/ime/arc_ime_bridge_impl.cc
index 13d787ef5eca056fcc8b2189b5b49b7b2709feb2..99abcd0a14ad14168f476957664b87d6722e14b6 100644
--- a/components/arc/ime/arc_ime_bridge_impl.cc
+++ b/components/arc/ime/arc_ime_bridge_impl.cc
@@ -141,10 +141,8 @@ void ArcImeBridgeImpl::OnTextInputTypeChanged(mojom::TextInputType type) {
delegate_->OnTextInputTypeChanged(ConvertTextInputType(type));
}
-void ArcImeBridgeImpl::OnCursorRectChanged(mojom::CursorRectPtr rect) {
- delegate_->OnCursorRectChanged(gfx::Rect(rect->left, rect->top,
- rect->right - rect->left,
- rect->bottom - rect->top));
+void ArcImeBridgeImpl::OnCursorRectChanged(gfx::Rect rect) {
+ delegate_->OnCursorRectChanged(rect);
}
void ArcImeBridgeImpl::OnCancelComposition() {
@@ -155,4 +153,13 @@ void ArcImeBridgeImpl::ShowImeIfNeeded() {
delegate_->ShowImeIfNeeded();
}
+void ArcImeBridgeImpl::OnCursorRectChangedWithSurroundingText(
+ gfx::Rect rect,
+ gfx::Range text_range,
+ const std::string& text_in_range,
+ gfx::Range selection_range) {
+ delegate_->OnCursorRectChangedWithSurroundingText(
+ rect, text_range, base::UTF8ToUTF16(text_in_range), selection_range);
+}
+
} // namespace arc
« no previous file with comments | « components/arc/ime/arc_ime_bridge_impl.h ('k') | components/arc/ime/arc_ime_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698