Implement GetTextFromRange(), GetTextRange() and GetSelectionRange() for ArcImeService.

components/arc/common/ime.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Next MinVersion: 5
+// Next MinVersion: 6
 
 module arc.mojom;
 
 import "screen_rect.mojom";
 
 // Represents the type of text input field currently focused.
 [Extensible]
 enum TextInputType {
   NONE,
   TEXT,
   PASSWORD,
   SEARCH,
   EMAIL,
   NUMBER,
   TELEPHONE,
   URL,
   DATE,
   TIME,
   DATETIME,
 };
 
 // Represents the text insertion points in the container screen coordinates.
 struct CursorRect {
   int32 left;
   int32 top;
   int32 right;
   int32 bottom;
 };
 
+[MinVersion=5]
+struct TextRange {
+  uint32 start;
+  uint32 end;

[hidehiko, 2017/05/11 14:32:31]

Is |end| inclusive or exclusive? As this is interface between Chrome and ARC,
could you explicitly document it?

[yhanada, 2017/05/12 07:52:06]

Done.

+};
+
 // Represents a single segment of text currently composed by IME.
 struct CompositionSegment {
   // Start offset of the segment in UTF-16 index.
   uint32 start_offset;
   // End offset of the segment in UTF-16 index.
   uint32 end_offset;
   // Indicates that this segment should be emphasized.
   bool emphasized;
 };
 
 // Next method ID: 4
 interface ImeHost {
   // Notifies Chrome that the text input focus is changed.
   OnTextInputTypeChanged@0(TextInputType type);
 
   // Notifies Chrome that the cursor poisition has changed.
   OnCursorRectChanged@1(CursorRect rect);

[kinaba, 2017/05/12 01:28:35]

Will this still be used or is left for backward compatibility only?
If the latter is the case, how about renaming it to
OnCursorRectChangedDeprecated@1 ? (with a comment)

[yhanada, 2017/05/12 07:52:06]

This will be used when failing to get the text and the selection range in
Android side.

 
   // Notifies Chrome that the current composition is canceled.
   [MinVersion=1] OnCancelComposition@2();
 
   // Show virtual keyboard of Chrome OS if needed.
   [MinVersion=2] ShowImeIfNeeded@3();
+
+  // Notifies Chrome that the cursor position has changed and
+  // also sends surrounding text.
+  [MinVersion=5] OnCursorRectChangedWithSurroundingText@4(

[hidehiko, 2017/05/11 14:32:31]

Could you document the args? Specifically what is the different between
|text_range| and |selection_range| passed here?

[kinaba, 2017/05/12 01:28:35]

Could you also add a comment why all these info are piggy-backed
into a single method?  (I.e., e.g., because Chrome OS IME tries
to retrieve these information synchronously, we need to update them
all at once to keep consistency, etc)

[yhanada, 2017/05/12 07:52:06]

Done.

+      CursorRect rect, TextRange text_range, string text_in_range,
+      TextRange selection_range);
 };
 
 // Next method ID: 6
 interface ImeInstance {
   Init@0(ImeHost host_ptr);
 
   // Sets composition text and attributes requested by the host IME.
   SetCompositionText@1(string text, array<CompositionSegment> segments);
 
   // Commits the last set composition text and clears the composition.
   ConfirmCompositionText@2();
 
   // Commits the specified text and clears the composition.
   InsertText@3(string text);
 
   // Informs the virtual keyboard bounds on screen is changing.
   // |new_bounds| Represents a ChromeOS virtual keyboard bounds in ChromeOS
   // screen coordinate, physical pixel as a unit.
   // When all members are zero value, virtual keyboard is being hidden.
   [MinVersion=3] OnKeyboardBoundsChanging@4(ScreenRect new_bounds);
 
   // Deletes current selection plus the specified number of char16 values
   // before and after selection or caret.
   [MinVersion=4] ExtendSelectionAndDelete@5(uint64 before, uint64 after);
 };