Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1584)

Unified Diff: chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc

Issue 2876693002: Emit UMAs for metrics from memory instrumentation service. (Closed)
Patch Set: comments from ssid. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/process_memory_metrics_emitter.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
diff --git a/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc b/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..173ebe02612d4185a20e5d9a3f6f364494234f22
--- /dev/null
+++ b/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
@@ -0,0 +1,52 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/metrics/process_memory_metrics_emitter.h"
+
+#include "base/message_loop/message_loop.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "content/public/test/test_utils.h"
+
+namespace {
+
+class ProcessMemoryMetricsEmitterFake : public ProcessMemoryMetricsEmitter {
+ public:
+ ProcessMemoryMetricsEmitterFake() {}
+
+ private:
+ ~ProcessMemoryMetricsEmitterFake() override {}
+
+ void ReceivedMemoryDump(
+ uint64_t dump_guid,
dcheng 2017/05/11 22:12:27 FWIW, I still think the typical expectation for "g
erikchen 2017/05/11 22:18:47 @primiano: thakis and I had a discussion about bir
Nico 2017/05/11 22:24:38 IIRC the numbers were like "there's a 5% chance th
+ bool success,
+ memory_instrumentation::mojom::GlobalMemoryDumpPtr ptr) override {
+ EXPECT_TRUE(success);
+ base::MessageLoop::current()->QuitWhenIdle();
+ }
+
+ DISALLOW_COPY_AND_ASSIGN(ProcessMemoryMetricsEmitterFake);
+};
+
+} // namespace
+
+class ProcessMemoryMetricsEmitterTest : public InProcessBrowserTest {
+ public:
+ ProcessMemoryMetricsEmitterTest() {}
+ ~ProcessMemoryMetricsEmitterTest() override {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(ProcessMemoryMetricsEmitterTest);
+};
+
+IN_PROC_BROWSER_TEST_F(ProcessMemoryMetricsEmitterTest, FetchAndEmitMetrics) {
+ // Intentionally let emitter leave scope to check that it correctly keeps
+ // itself alive.
+ {
+ scoped_refptr<ProcessMemoryMetricsEmitterFake> emitter(
+ new ProcessMemoryMetricsEmitterFake);
+ emitter->FetchAndEmitProcessMemoryMetrics();
+ }
+
+ content::RunMessageLoop();
+}
« no previous file with comments | « chrome/browser/metrics/process_memory_metrics_emitter.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698