Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: ash/public/interfaces/lock_screen.mojom

Issue 2876673002: mojo api for view based lockscreen (Closed)
Patch Set: comments and rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/public/interfaces/BUILD.gn ('k') | ash/shell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/public/interfaces/lock_screen.mojom
diff --git a/ash/public/interfaces/lock_screen.mojom b/ash/public/interfaces/lock_screen.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..e563f883c61ee05e037b19885da31d403906f817
--- /dev/null
+++ b/ash/public/interfaces/lock_screen.mojom
@@ -0,0 +1,25 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module ash.mojom;
+
+import "components/signin/public/interfaces/account_id.mojom";
+
+// Allows clients (e.g. Chrome browser) to control the ash lock screen.
+interface LockScreen {
+ // Sets the client interface.
+ SetClient(LockScreenClient client);
+
+ // Shows error message in the ash lock screen.
+ ShowErrorMessage();
xiyuan 2017/05/11 21:17:33 Do we need the error message to be displayed?
xiaoyinh(OOO Sep 11-29) 2017/05/13 00:29:49 chrome will request to show error message when the
xiyuan 2017/05/15 20:39:41 Sorry, I should be more clear. I meant how would L
+};
+
+// Allows ash lock screen to control a client (e.g. Chrome browser). Requests
+// often involve preferences or talk to cryptohome that is not available to ash.
+interface LockScreenClient {
+ // Request user authentication in chrome.
xiyuan 2017/05/11 21:17:33 nit: Document what happens when auth succeeds or f
xiaoyinh(OOO Sep 11-29) 2017/05/13 00:29:49 Done.
+ AuthenticateUser(signin.mojom.AccountId account_id,
+ string password,
xiyuan 2017/05/11 21:17:33 Transfer plain password over mojo makes me nervous
xiaoyinh(OOO Sep 11-29) 2017/05/13 00:29:49 Thanks. The new patch hash the password in LockScr
+ bool authenticated_by_pin);
+};
« no previous file with comments | « ash/public/interfaces/BUILD.gn ('k') | ash/shell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698