Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/chromeos/login/lock/screen_locker.cc

Issue 2876673002: mojo api for view based lockscreen (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/lock/screen_locker.cc
diff --git a/chrome/browser/chromeos/login/lock/screen_locker.cc b/chrome/browser/chromeos/login/lock/screen_locker.cc
index 0d1730e08e86ce9b4f0b21de6a0a4a69c68935c2..85d5b42aea36671c9f42a940fb32209ab6dafc93 100644
--- a/chrome/browser/chromeos/login/lock/screen_locker.cc
+++ b/chrome/browser/chromeos/login/lock/screen_locker.cc
@@ -42,6 +42,7 @@
#include "chrome/browser/signin/easy_unlock_service.h"
#include "chrome/browser/signin/signin_manager_factory.h"
#include "chrome/browser/ui/ash/ash_util.h"
+#include "chrome/browser/ui/ash/lock_screen_client_chromeos.h"
#include "chrome/browser/ui/ash/session_controller_client.h"
#include "chrome/browser/ui/webui/chromeos/login/screenlock_icon_provider.h"
#include "chrome/browser/ui/webui/chromeos/login/screenlock_icon_source.h"
@@ -292,6 +293,9 @@ void ScreenLocker::OnAuthFailure(const AuthFailure& error) {
? IDS_LOGIN_ERROR_AUTHENTICATING_2ND_TIME
: IDS_LOGIN_ERROR_AUTHENTICATING,
HelpAppLauncher::HELP_CANT_ACCESS_ACCOUNT);
+ // TODO(xiaoyinh@): This call should replace delegate_->ShowErrorMessage
+ // above when the implementation is complete.
+ LockScreenClientChromeOS::Get()->ShowErrorMessage();
jdufault 2017/05/11 01:14:51 Can you make another delegate_ implementation that
xiaoyinh(OOO Sep 11-29) 2017/05/11 20:29:52 How about reuse StubDelegate in the above?
jdufault 2017/05/11 20:34:06 sg, please rename it to MojoDelegate or similar.
if (auth_status_consumer_)
auth_status_consumer_->OnAuthFailure(error);

Powered by Google App Engine
This is Rietveld 408576698