Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc

Issue 2876633002: Add a PersistentStore to FeatureEngagementTracker (Closed)
Patch Set: Fix deps Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc
diff --git a/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc b/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc
index aa0f23e7cfee91c62c8ffb55925cf8ab122d1176..b1a8f937d061dbb7a2acd9179a030c43feb0d411 100644
--- a/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc
+++ b/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc
@@ -14,10 +14,12 @@
#include "components/feature_engagement_tracker/internal/never_condition_validator.h"
#include "components/feature_engagement_tracker/internal/never_storage_validator.h"
#include "components/feature_engagement_tracker/internal/once_condition_validator.h"
+#include "components/feature_engagement_tracker/internal/persistent_store.h"
#include "components/feature_engagement_tracker/internal/single_invalid_configuration.h"
#include "components/feature_engagement_tracker/internal/system_time_provider.h"
#include "components/feature_engagement_tracker/public/feature_constants.h"
#include "components/feature_engagement_tracker/public/feature_list.h"
+#include "components/leveldb_proto/proto_database_impl.h"
namespace feature_engagement_tracker {
@@ -53,11 +55,16 @@ CreateDemoModeFeatureEngagementTracker() {
// static
FeatureEngagementTracker* FeatureEngagementTracker::Create(
const base::FilePath& storage_dir,
- const scoped_refptr<base::SequencedTaskRunner>& background__task_runner) {
+ const scoped_refptr<base::SequencedTaskRunner>& background_task_runner) {
if (base::FeatureList::IsEnabled(kIPHDemoMode))
return CreateDemoModeFeatureEngagementTracker().release();
- std::unique_ptr<Store> store = base::MakeUnique<InMemoryStore>();
+ std::unique_ptr<leveldb_proto::ProtoDatabase<Event>> db =
+ base::MakeUnique<leveldb_proto::ProtoDatabaseImpl<Event>>(
+ background_task_runner);
+
+ std::unique_ptr<Store> store =
+ base::MakeUnique<PersistentStore>(storage_dir, std::move(db));
std::unique_ptr<Configuration> configuration =
base::MakeUnique<SingleInvalidConfiguration>();
std::unique_ptr<ConditionValidator> condition_validator =

Powered by Google App Engine
This is Rietveld 408576698