Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm

Issue 2876603005: [Payment Request] Refactors the edit view controller (Closed)
Patch Set: Addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm
diff --git a/ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm b/ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm
index 527d77267b23678e1a32729d12034fcf2a573d51..1b664af2cf3dd63e4618b939f94e9b4ed26d8e63 100644
--- a/ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm
+++ b/ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm
@@ -63,22 +63,32 @@ MATCHER_P5(CreditCardMatches,
NSArray<EditorField*>* GetEditorFields() {
return @[
[[EditorField alloc] initWithAutofillUIType:AutofillUITypeCreditCardNumber
+ fieldType:EditorFieldTypeTextField
label:@"Credit Card Number"
value:@"4111111111111111" /* Visa */
required:YES],
[[EditorField alloc]
initWithAutofillUIType:AutofillUITypeCreditCardHolderFullName
+ fieldType:EditorFieldTypeTextField
label:@"Cardholder Name"
value:@"John Doe"
required:YES],
[[EditorField alloc] initWithAutofillUIType:AutofillUITypeCreditCardExpMonth
+ fieldType:EditorFieldTypeTextField
label:@"Expiration Month"
value:@"12"
required:YES],
[[EditorField alloc] initWithAutofillUIType:AutofillUITypeCreditCardExpYear
+ fieldType:EditorFieldTypeTextField
label:@"Expiration Year"
value:@"2090"
required:YES],
+ [[EditorField alloc]
+ initWithAutofillUIType:AutofillUITypeCreditCardBillingAddress
+ fieldType:EditorFieldTypeSelector
+ label:@"Billing Address"
+ value:@"12345"
+ required:YES],
];
}
@@ -170,7 +180,6 @@ TEST_F(PaymentRequestCreditCardEditCoordinatorTest, DidFinishCreatingWithSave) {
navigation_controller.visibleViewController);
[coordinator creditCardEditViewController:view_controller
didFinishEditingFields:GetEditorFields()
- billingAddressID:@"12345"
saveCreditCard:YES];
EXPECT_OCMOCK_VERIFY(delegate);
@@ -221,7 +230,6 @@ TEST_F(PaymentRequestCreditCardEditCoordinatorTest, DidFinishCreatingNoSave) {
navigation_controller.visibleViewController);
[coordinator creditCardEditViewController:view_controller
didFinishEditingFields:GetEditorFields()
- billingAddressID:@"12345"
saveCreditCard:NO];
EXPECT_OCMOCK_VERIFY(delegate);
@@ -272,7 +280,6 @@ TEST_F(PaymentRequestCreditCardEditCoordinatorTest, DidFinishEditing) {
navigation_controller.visibleViewController);
[coordinator creditCardEditViewController:view_controller
didFinishEditingFields:GetEditorFields()
- billingAddressID:@"12345"
saveCreditCard:YES];
EXPECT_OCMOCK_VERIFY(delegate);

Powered by Google App Engine
This is Rietveld 408576698