Linux native notifications: Add attribution

chrome/browser/notifications/notification_platform_bridge_linux.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_platform_bridge_linux.h"
 
 #include <algorithm>
 #include <memory>
 #include <set>
 #include <unordered_map>
@@ skipping 13 matching lines @@
 #include "base/task_scheduler/post_task.h"
 #include "base/version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/notifications/native_notification_display_service.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_display_service_factory.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/shell_integration_linux.h"
 #include "chrome/grit/generated_resources.h"
+#include "components/url_formatter/elide_url.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "dbus/bus.h"
 #include "dbus/message.h"
 #include "dbus/object_proxy.h"
 #include "skia/ext/image_operations.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/image/image_skia.h"
 
 namespace {
@@ skipping 76 matching lines @@
   return title;
 }
 
 gfx::Image DeepCopyImage(const gfx::Image& image) {
   if (image.IsEmpty())
     return gfx::Image();
   std::unique_ptr<gfx::ImageSkia> image_skia(image.CopyImageSkia());
   return gfx::Image(*image_skia);
 }
 
+void EscapeBodyText(std::string* text) {
+  base::ReplaceSubstringsAfterOffset(text, 0, "&", "&amp;");
+  base::ReplaceSubstringsAfterOffset(text, 0, "<", "&lt;");
+  base::ReplaceSubstringsAfterOffset(text, 0, ">", "&gt;");
+}
+
 int NotificationPriorityToFdoUrgency(int priority) {
   enum FdoUrgency {
     LOW = 0,
     NORMAL = 1,
     CRITICAL = 2,
   };
   switch (priority) {
     case message_center::MIN_PRIORITY:
     case message_center::LOW_PRIORITY:
       return LOW;
     case message_center::HIGH_PRIORITY:
     case message_center::MAX_PRIORITY:
       return CRITICAL;
     default:
       NOTREACHED();
     case message_center::DEFAULT_PRIORITY:
       return NORMAL;
   }
 }
 
 // Constrain |image|'s size to |kMaxImageWidth|x|kMaxImageHeight|. If
 // the image does not need to be resized, or the image is empty,
 // returns |image| directly.
 gfx::Image ResizeImageToFdoMaxSize(const gfx::Image& image) {
+  DCHECK(!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (image.IsEmpty())
     return image;
   int width = image.Width();
   int height = image.Height();
   if (width <= kMaxImageWidth && height <= kMaxImageHeight) {
     return image;
   }
   const SkBitmap* image_bitmap = image.ToSkBitmap();
   double scale = std::min(static_cast<double>(kMaxImageWidth) / width,
                           static_cast<double>(kMaxImageHeight) / height);
@@ skipping 363 matching lines @@
     // app_icon passed implicitly via desktop-entry.
     writer.AppendString("");
 
     writer.AppendString(
         base::UTF16ToUTF8(CreateNotificationTitle(*notification)));
 
     StringStreamSizable body;
     if (base::ContainsKey(capabilities_, kCapabilityBody)) {
       const bool body_markup =
           base::ContainsKey(capabilities_, kCapabilityBodyMarkup);
+
+      if (notification->UseOriginAsContextMessage()) {
+        std::string url_display_text =
+            base::UTF16ToUTF8(url_formatter::FormatUrlForSecurityDisplay(
+                notification->origin_url(),
+                url_formatter::SchemeDisplay::OMIT_HTTP_AND_HTTPS));
+        std::string spec = notification->origin_url().spec();

[Lei Zhang, 2017/05/15 22:19:59]

Do we know if the origin URL is guaranteed to be valid at this point?

[Peter Beverloo, 2017/05/15 22:43:26]

Yes. UseOriginAsContextMessage() verifies this.

+        if (base::ContainsKey(capabilities_, kCapabilityBodyHyperlinks)) {
+          body << "<a href=\"" << spec << "\">" << url_display_text << "</a>";
+        } else {
+          body << url_display_text;
+        }
+      } else if (!notification->context_message().empty()) {
+        std::string context =
+            base::UTF16ToUTF8(notification->context_message());
+        if (body_markup)
+          EscapeBodyText(&context);

[Peter Beverloo, 2017/05/15 22:43:26]

Is it possible for |body_markup| to be FALSE but kCapabilityBodyHyperlinks to be
TRUE, like we check on line 552? In that case <a> would still work if we don't
escape.

[Tom (Use chromium acct), 2017/05/16 04:43:34]

no. body-hyperlinks => body-markup

+        body << context;
+      }
+
       std::string message = base::UTF16ToUTF8(notification->message());
-      if (body_markup) {
-        base::ReplaceSubstringsAfterOffset(&message, 0, "&", "&amp;");
-        base::ReplaceSubstringsAfterOffset(&message, 0, "<", "&lt;");
-        base::ReplaceSubstringsAfterOffset(&message, 0, ">", "&gt;");
-      }
+      if (body_markup)
+        EscapeBodyText(&message);
+      if (body.size())
+        body << "\n";
       body << message;
 
       if (notification->type() == message_center::NOTIFICATION_TYPE_MULTIPLE) {
         for (const auto& item : notification->items()) {
           if (body.size())
             body << "\n";
           const std::string title = base::UTF16ToUTF8(item.title);
           const std::string message = base::UTF16ToUTF8(item.message);
           // TODO(peter): Figure out the right way to internationalize
           // this for RTL languages.
@@ skipping 367 matching lines @@
 }
 
 void NotificationPlatformBridgeLinux::SetReadyCallback(
     NotificationBridgeReadyCallback callback) {
   impl_->SetReadyCallback(std::move(callback));
 }
 
 void NotificationPlatformBridgeLinux::CleanUp() {
   impl_->CleanUp();
 }