Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2499)

Unified Diff: base/trace_event/memory_peak_detector_unittest.cc

Issue 2876543002: memory-infra: Don't invoke all dump providers in SUMMARY_ONLY mode (Closed)
Patch Set: fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_peak_detector_unittest.cc
diff --git a/base/trace_event/memory_peak_detector_unittest.cc b/base/trace_event/memory_peak_detector_unittest.cc
index c158466d6ea565a10e85b267ff31bf76172cb1a9..1b141993802beddb05b3617c9fd468f63ce3d622 100644
--- a/base/trace_event/memory_peak_detector_unittest.cc
+++ b/base/trace_event/memory_peak_detector_unittest.cc
@@ -176,8 +176,8 @@ class MemoryPeakDetectorTest : public testing::Test {
std::unique_ptr<MockMemoryDumpProvider> mdp(new MockMemoryDumpProvider());
MemoryDumpProvider::Options opt;
opt.is_fast_polling_supported = true;
- scoped_refptr<MemoryDumpProviderInfo> mdp_info(
- new MemoryDumpProviderInfo(mdp.get(), "Mock MDP", nullptr, opt, false));
+ scoped_refptr<MemoryDumpProviderInfo> mdp_info(new MemoryDumpProviderInfo(
+ mdp.get(), "Mock MDP", nullptr, opt, false, false));
ssid 2017/05/10 17:43:08 nit: can you make it false /* whitelisted_for_bac
hjd 2017/05/15 12:02:27 Done.
// The |mdp| instance will be destroyed together with the |mdp_info|.
mdp_info->owned_dump_provider = std::move(mdp);

Powered by Google App Engine
This is Rietveld 408576698