Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: pkg/kernel/lib/type_checker.dart

Issue 2876533004: Add FunctionType.getNamedParameter. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/kernel/lib/ast.dart ('K') | « pkg/kernel/lib/ast.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/type_checker.dart
diff --git a/pkg/kernel/lib/type_checker.dart b/pkg/kernel/lib/type_checker.dart
index 6c48a6d91d17175c928b6e0c574200e659ab3fb9..f32ae870cdd3f9a133f171d228c6e5397633e9c4 100644
--- a/pkg/kernel/lib/type_checker.dart
+++ b/pkg/kernel/lib/type_checker.dart
@@ -497,19 +497,13 @@ class TypeCheckingVisitor
}
for (int i = 0; i < arguments.named.length; ++i) {
var argument = arguments.named[i];
- bool found = false;
- for (int j = 0; j < function.namedParameters.length; ++j) {
- if (argument.name == function.namedParameters[j].name) {
- var expectedType = instantiation.substituteType(
- function.namedParameters[j].type,
- contravariant: true);
- argument.value =
- checkAndDowncastExpression(argument.value, expectedType);
- found = true;
- break;
- }
- }
- if (!found) {
+ var parameterType = function.getNamedParameter(argument.name);
+ if (parameterType != null) {
+ var expectedType =
+ instantiation.substituteType(parameterType, contravariant: true);
+ argument.value =
+ checkAndDowncastExpression(argument.value, expectedType);
+ } else {
fail(argument.value, 'Unexpected named parameter: ${argument.name}');
return const BottomType();
}
« pkg/kernel/lib/ast.dart ('K') | « pkg/kernel/lib/ast.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698