Add FunctionType.getNamedParameter.

Add FunctionType.getNamedParameter.

This functionality was duplicated both in
TypeCheckingVisitor.handleFunctionCall and in the front end's
TypeInferrerImpl._getCalleeFunctionType.  I kept the implementation
from TypeInferrerImpl._getCalleeFunctionType since it does a binary
search, so it should theoretically be faster.

R=kmillikin@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/06bba1e5517631d55bcf8e4d4160b5688ec476e5

[Paul Berry, 2017-05-10 17:59:07]

paulberry@google.com changed reviewers:
+ asgerf@google.com, scheglov@google.com

[Paul Berry, 2017-05-10 17:59:07]

Asger, can you review the kernel changes?
Konstantin, can you review the front_end changes?

[scheglov, 2017-05-10 18:03:36]

LGTM

https://codereview.chromium.org/2876533004/diff/1/pkg/kernel/lib/ast.dart
File pkg/kernel/lib/ast.dart (right):

https://codereview.chromium.org/2876533004/diff/1/pkg/kernel/lib/ast.dart#new...
pkg/kernel/lib/ast.dart:4002: int comparison =
name.compareTo(namedParameters[pivot].name);
It should be slightly faster to extract `namedParameters[pivot]` into a local
variable and reuse when we found the name.

[Paul Berry, 2017-05-10 18:16:08]

https://codereview.chromium.org/2876533004/diff/1/pkg/kernel/lib/ast.dart
File pkg/kernel/lib/ast.dart (right):

https://codereview.chromium.org/2876533004/diff/1/pkg/kernel/lib/ast.dart#new...
pkg/kernel/lib/ast.dart:4002: int comparison =
name.compareTo(namedParameters[pivot].name);
On 2017/05/10 18:03:35, scheglov wrote:
> It should be slightly faster to extract `namedParameters[pivot]` into a local
> variable and reuse when we found the name.

Done.

[Paul Berry, 2017-05-11 12:54:22]

paulberry@google.com changed reviewers:
+ kmillikin@google.com

[Paul Berry, 2017-05-11 12:54:23]

Adding kmillikin as reviewer for kernel since Asger has been out

[Kevin Millikin (Google), 2017-05-11 12:57:15]

LGTM.

[Paul Berry, 2017-05-11 13:03:42]

Description was changed from

==========
Add FunctionType.getNamedParameter.

This functionality was duplicated both in
TypeCheckingVisitor.handleFunctionCall and in the front end's
TypeInferrerImpl._getCalleeFunctionType.  I kept the implementation
from TypeInferrerImpl._getCalleeFunctionType since it does a binary
search, so it should theoretically be faster.
==========

to

==========
Add FunctionType.getNamedParameter.

This functionality was duplicated both in
TypeCheckingVisitor.handleFunctionCall and in the front end's
TypeInferrerImpl._getCalleeFunctionType.  I kept the implementation
from TypeInferrerImpl._getCalleeFunctionType since it does a binary
search, so it should theoretically be faster.

R=kmillikin@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/06bba1e5517631d55bcf8e4d4160b5688ec476e5
==========

[Paul Berry, 2017-05-11 13:03:43]

Committed patchset #2 (id:20001) manually as
06bba1e5517631d55bcf8e4d4160b5688ec476e5 (presubmit successful).