Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3766)

Unified Diff: chrome/browser/ui/views/session_crashed_bubble_view.h

Issue 287653004: Schedule posttask to decide Uma optin option offering (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Nit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/session_crashed_bubble_view.h
diff --git a/chrome/browser/ui/views/session_crashed_bubble_view.h b/chrome/browser/ui/views/session_crashed_bubble_view.h
index 8986da6c983bff5b01a1727d9b83bd3db93ab84b..7c204888d8c724090e3b65c71ab3994ebd993f9d 100644
--- a/chrome/browser/ui/views/session_crashed_bubble_view.h
+++ b/chrome/browser/ui/views/session_crashed_bubble_view.h
@@ -41,11 +41,21 @@ class SessionCrashedBubbleView
static void Show(Browser* browser);
private:
+ // A helper class that listens to browser removal event.
+ class BrowserRemovalObserver;
+
SessionCrashedBubbleView(views::View* anchor_view,
Browser* browser,
- content::WebContents* web_contents);
+ content::WebContents* web_contents,
+ bool offer_uma_optin);
virtual ~SessionCrashedBubbleView();
+ // Creates and shows the session crashed bubble, with |offer_uma_optin|
+ // indicating whether the UMA opt-in checkbox should be shown. Called
+ // by Show() after checking whether the UMA option should be presented.
Alexei Svitkine (slow) 2014/05/21 07:23:00 Nit: Expand comment to mention that it takes owner
yao 2014/05/21 14:13:20 Done.
+ static void ShowForReal(BrowserRemovalObserver* browser_observer,
+ bool offer_uma_optin);
+
// WidgetDelegateView methods.
virtual views::View* GetInitiallyFocusedView() OVERRIDE;
@@ -112,6 +122,9 @@ class SessionCrashedBubbleView
// Checkbox for the user to opt-in to UMA reporting.
views::Checkbox* uma_option_;
+ // Whether or not the UMA opt-in option should be shown.
+ bool offer_uma_optin_;
+
// Whether or not a navigation has started on current tab.
bool started_navigation_;

Powered by Google App Engine
This is Rietveld 408576698