Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: chrome/browser/ui/views/session_crashed_bubble_view.h

Issue 287653004: Schedule posttask to decide Uma optin option offering (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Nit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/session_crashed_bubble_view.h
diff --git a/chrome/browser/ui/views/session_crashed_bubble_view.h b/chrome/browser/ui/views/session_crashed_bubble_view.h
index 8986da6c983bff5b01a1727d9b83bd3db93ab84b..61e649c1fde298ced30d13aa765b19dd67c23f21 100644
--- a/chrome/browser/ui/views/session_crashed_bubble_view.h
+++ b/chrome/browser/ui/views/session_crashed_bubble_view.h
@@ -25,6 +25,10 @@ class WebContents;
class RenderViewHost;
}
+namespace {
+ class BrowserRemovalObserver;
Alexei Svitkine (slow) 2014/05/20 15:52:42 I think you can make it an inner class inside Sess
yao 2014/05/20 16:25:44 Done.
+}
+
class Browser;
// It creates a session restore request bubble when the previous session has
@@ -43,9 +47,17 @@ class SessionCrashedBubbleView
private:
SessionCrashedBubbleView(views::View* anchor_view,
Browser* browser,
- content::WebContents* web_contents);
+ content::WebContents* web_contents,
+ bool offer_uma_optin);
virtual ~SessionCrashedBubbleView();
+ // Creates and shows the session crashed bubble, with |offer_uma_optin|
+ // indicating whether the UMA opt-in checkbox should be shown. Called
+ // by Show() after checking whether the UMA option should be presented.
+ static void ShowForReal(BrowserRemovalObserver* browser_observer,
+ Browser* browser,
+ bool offer_uma_optin);
+
// WidgetDelegateView methods.
virtual views::View* GetInitiallyFocusedView() OVERRIDE;
@@ -112,6 +124,9 @@ class SessionCrashedBubbleView
// Checkbox for the user to opt-in to UMA reporting.
views::Checkbox* uma_option_;
+ // Whether or not the UMA opt-in option should be shown.
+ bool offer_uma_optin_;
+
// Whether or not a navigation has started on current tab.
bool started_navigation_;

Powered by Google App Engine
This is Rietveld 408576698