Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2876473003: [ABANDONED] [WIP] Refactor SafeBrowsingResourceThrottle in preparation for WebSocket (Closed)

Created:
3 years, 7 months ago by Adam Rice
Modified:
3 years, 4 months ago
Reviewers:
CC:
chromium-reviews, vakh+watch_chromium.org, droger+watchlist_chromium.org, grt+watch_chromium.org, sdefresne+watchlist_chromium.org, Randy Smith (Not in Mondays), timvolodine, blundell+watchlist_chromium.org, loading-reviews_chromium.org, android-webview-reviews_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] Refactor SafeBrowsingResourceThrottle in preparation for WebSocket Factor safe_browsing::RequestChecker out of safe_browsing::BaseResourceThrottle. Make BaseResourceThrottle a concrete class and rename it to safe_browsing::ResourceThrottle. Modify users of SafeBrowsingResourceThrottle and AwSafeBrowsingResourceThrottle to construct a safe_browsing::ResourceThrottle object with a delegate object implementing their specific functionality. See the design doc at https://docs.google.com/document/d/1iR3XMIQukqlXb6ajIHE91apHZAxyF_wvRoB5JGeJYPs/edit. Also adds tests for RequestChecker. BUG=644744

Patch Set 1 #

Patch Set 2 : Fix the BUILD.gn deps #

Patch Set 3 : Fix dependencies for request_checker_unittests #

Patch Set 4 : Rebase #

Patch Set 5 : compile fixes #

Patch Set 6 : Finish unit tests #

Patch Set 7 : Minor fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1223 lines, -964 lines) Patch
M android_webview/browser/aw_safe_browsing_resource_throttle.h View 1 2 3 4 5 6 1 chunk +19 lines, -31 lines 0 comments Download
M android_webview/browser/aw_safe_browsing_resource_throttle.cc View 1 2 3 4 5 6 1 chunk +57 lines, -21 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 2 3 4 5 6 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 4 5 6 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/loader/safe_browsing_resource_throttle.h View 1 2 3 4 5 6 3 chunks +8 lines, -51 lines 0 comments Download
M chrome/browser/loader/safe_browsing_resource_throttle.cc View 1 2 3 4 5 6 3 chunks +55 lines, -57 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing/BUILD.gn View 1 2 3 2 chunks +24 lines, -2 lines 0 comments Download
M components/safe_browsing/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
D components/safe_browsing/base_resource_throttle.h View 1 chunk +0 lines, -194 lines 0 comments Download
D components/safe_browsing/base_resource_throttle.cc View 1 2 3 1 chunk +0 lines, -414 lines 0 comments Download
M components/safe_browsing/base_ui_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
A components/safe_browsing/request_checker.h View 1 2 3 4 5 6 1 chunk +196 lines, -0 lines 0 comments Download
A + components/safe_browsing/request_checker.cc View 1 2 3 4 5 6 12 chunks +132 lines, -179 lines 0 comments Download
A components/safe_browsing/request_checker_unittest.cc View 1 2 3 4 5 6 1 chunk +504 lines, -0 lines 0 comments Download
A components/safe_browsing/resource_throttle.h View 1 2 3 4 5 6 1 chunk +103 lines, -0 lines 0 comments Download
A components/safe_browsing/resource_throttle.cc View 1 2 3 4 5 6 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (22 generated)
Adam Rice
The CQ bit was checked by ricea@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-10 10:05:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876473003/1
3 years, 7 months ago (2017-05-10 10:06:21 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-10 10:11:34 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/265599) android_compile_dbg on ...
3 years, 7 months ago (2017-05-10 10:11:35 UTC) #4
Adam Rice
The CQ bit was checked by ricea@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-10 13:31:14 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876473003/20001
3 years, 7 months ago (2017-05-10 13:32:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-10 13:36:41 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/174772) linux_chromium_chromeos_rel_ng on ...
3 years, 7 months ago (2017-05-10 13:36:41 UTC) #8
Adam Rice
The CQ bit was checked by ricea@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-19 03:39:05 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876473003/40001
3 years, 7 months ago (2017-05-19 03:42:14 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-19 03:46:27 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/142863) ios-device on ...
3 years, 7 months ago (2017-05-19 03:46:28 UTC) #12
Adam Rice
The CQ bit was checked by ricea@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-19 05:23:13 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876473003/60001
3 years, 7 months ago (2017-05-19 05:23:55 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-19 05:39:14 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/458033)
3 years, 7 months ago (2017-05-19 05:39:15 UTC) #16
Adam Rice
The CQ bit was checked by ricea@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 23:46:23 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876473003/80001
3 years, 7 months ago (2017-05-22 23:47:03 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 23:50:26 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/216457) ios-device-xcode-clang on ...
3 years, 7 months ago (2017-05-22 23:50:27 UTC) #20
Adam Rice
Patchset #8 (id:140001) has been deleted
3 years, 6 months ago (2017-06-12 07:29:39 UTC) #21
Adam Rice
3 years, 4 months ago (2017-07-27 08:57:09 UTC) #22 
Description was changed from

==========
[WIP] Refactor SafeBrowsingResourceThrottle in preparation for WebSocket

Factor safe_browsing::RequestChecker out of
safe_browsing::BaseResourceThrottle. Make BaseResourceThrottle a concrete class
and rename it to safe_browsing::ResourceThrottle. Modify users of
SafeBrowsingResourceThrottle and AwSafeBrowsingResourceThrottle to construct a
safe_browsing::ResourceThrottle object with a delegate object implementing their
specific functionality.

See the design doc at
https://docs.google.com/document/d/1iR3XMIQukqlXb6ajIHE91apHZAxyF_wvRoB5JGeJY....

Also adds tests for RequestChecker.

BUG=644744
==========

to

==========
[WIP] Refactor SafeBrowsingResourceThrottle in preparation for WebSocket

Factor safe_browsing::RequestChecker out of
safe_browsing::BaseResourceThrottle. Make BaseResourceThrottle a concrete class
and rename it to safe_browsing::ResourceThrottle. Modify users of
SafeBrowsingResourceThrottle and AwSafeBrowsingResourceThrottle to construct a
safe_browsing::ResourceThrottle object with a delegate object implementing their
specific functionality.

See the design doc at
https://docs.google.com/document/d/1iR3XMIQukqlXb6ajIHE91apHZAxyF_wvRoB5JGeJY....

Also adds tests for RequestChecker.

BUG=644744
==========

Powered by Google App Engine
This is Rietveld 408576698