Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2102)

Unified Diff: chrome/browser/profiles/profile_io_data.cc

Issue 2876463007: Revert of Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_io_data.h ('k') | net/test/embedded_test_server/embedded_test_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_io_data.cc
diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc
index a236a5702173a3b4d03731fd28f67bd317388b60..2c31e7109c0f5de51f95ffe06721b42fbd0a4d3e 100644
--- a/chrome/browser/profiles/profile_io_data.cc
+++ b/chrome/browser/profiles/profile_io_data.cc
@@ -674,11 +674,6 @@
main_request_context_storage()->set_reporting_service(
std::unique_ptr<net::ReportingService>());
- // This should be shut down last, as any other requests may initiate more
- // activity when the ProxyService aborts lookups.
- if (proxy_service_)
- proxy_service_->OnShutdown();
-
// TODO(ajwong): These AssertNoURLRequests() calls are unnecessary since they
// are already done in the URLRequestContext destructor.
if (main_request_context_)
@@ -996,7 +991,7 @@
main_request_context_->set_enable_brotli(io_thread_globals->enable_brotli);
- std::unique_ptr<ChromeNetworkDelegate> chrome_network_delegate(
+ std::unique_ptr<ChromeNetworkDelegate> network_delegate(
new ChromeNetworkDelegate(
#if BUILDFLAG(ENABLE_EXTENSIONS)
io_thread_globals->extension_event_router_forwarder.get(),
@@ -1005,7 +1000,7 @@
#endif
&enable_referrers_));
#if BUILDFLAG(ENABLE_EXTENSIONS)
- chrome_network_delegate->set_extension_info_map(
+ network_delegate->set_extension_info_map(
profile_params_->extension_info_map.get());
if (!command_line.HasSwitch(switches::kDisableExtensionsHttpThrottling)) {
extension_throttle_manager_.reset(
@@ -1013,39 +1008,26 @@
}
#endif
- chrome_network_delegate->set_url_blacklist_manager(
- url_blacklist_manager_.get());
- chrome_network_delegate->set_profile(profile_params_->profile);
- chrome_network_delegate->set_profile_path(profile_params_->path);
- chrome_network_delegate->set_cookie_settings(
- profile_params_->cookie_settings.get());
- chrome_network_delegate->set_enable_do_not_track(&enable_do_not_track_);
- chrome_network_delegate->set_force_google_safe_search(
- &force_google_safesearch_);
- chrome_network_delegate->set_force_youtube_restrict(&force_youtube_restrict_);
- chrome_network_delegate->set_allowed_domains_for_apps(
- &allowed_domains_for_apps_);
- chrome_network_delegate->set_data_use_aggregator(
+ network_delegate->set_url_blacklist_manager(url_blacklist_manager_.get());
+ network_delegate->set_profile(profile_params_->profile);
+ network_delegate->set_profile_path(profile_params_->path);
+ network_delegate->set_cookie_settings(profile_params_->cookie_settings.get());
+ network_delegate->set_enable_do_not_track(&enable_do_not_track_);
+ network_delegate->set_force_google_safe_search(&force_google_safesearch_);
+ network_delegate->set_force_youtube_restrict(&force_youtube_restrict_);
+ network_delegate->set_allowed_domains_for_apps(&allowed_domains_for_apps_);
+ network_delegate->set_data_use_aggregator(
io_thread_globals->data_use_aggregator.get(), IsOffTheRecord());
-
- std::unique_ptr<net::NetworkDelegate> network_delegate =
- ConfigureNetworkDelegate(profile_params_->io_thread,
- std::move(chrome_network_delegate));
-
- main_request_context_->set_host_resolver(
- io_thread_globals->host_resolver.get());
// NOTE: Proxy service uses the default io thread network delegate, not the
// delegate just created.
proxy_service_ = ProxyServiceFactory::CreateProxyService(
- io_thread->net_log(), main_request_context_.get(), network_delegate.get(),
+ io_thread->net_log(),
+ io_thread_globals->proxy_script_fetcher_context.get(),
+ io_thread_globals->system_network_delegate.get(),
std::move(profile_params_->proxy_config_service), command_line,
io_thread->WpadQuickCheckEnabled(),
io_thread->PacHttpsUrlStrippingEnabled());
-
- main_request_context_storage_->set_network_delegate(
- std::move(network_delegate));
-
transport_security_state_.reset(new net::TransportSecurityState());
base::SequencedWorkerPool* pool = BrowserThread::GetBlockingPool();
transport_security_persister_.reset(
@@ -1137,8 +1119,8 @@
base::Bind(&IOThread::UnregisterSTHObserver, base::Unretained(io_thread),
ct_tree_tracker_.get());
- InitializeInternal(profile_params_.get(), protocol_handlers,
- std::move(request_interceptors));
+ InitializeInternal(std::move(network_delegate), profile_params_.get(),
+ protocol_handlers, std::move(request_interceptors));
profile_params_.reset();
initialized_ = true;
@@ -1328,13 +1310,6 @@
std::move(backend), false /* is_main_cache */);
}
-std::unique_ptr<net::NetworkDelegate> ProfileIOData::ConfigureNetworkDelegate(
- IOThread* io_thread,
- std::unique_ptr<ChromeNetworkDelegate> chrome_network_delegate) const {
- return base::WrapUnique<net::NetworkDelegate>(
- chrome_network_delegate.release());
-}
-
void ProfileIOData::SetCookieSettingsForTesting(
content_settings::CookieSettings* cookie_settings) {
DCHECK(!cookie_settings_.get());
« no previous file with comments | « chrome/browser/profiles/profile_io_data.h ('k') | net/test/embedded_test_server/embedded_test_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698