Issue 2876443002: Allow customization of client address used to generate and validate source address token

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2876443002: Allow customization of client address used to generate and validate source address token (Closed)

Created:
3 years, 7 months ago by mpw

Modified:
3 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow customization of client address used for stateless rejector to generate and validate source address token. Protected by FLAGS_quic_reloadable_flag_quic_use_client_address_for_stk_in_proxy. Merge internal change: 154755746 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -6 lines)			Patch
M	net/quic/core/quic_crypto_server_stream.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_crypto_server_stream.cc	View	4 chunks	+7 lines, -4 lines	0 comments	Download
M	net/quic/core/quic_flags_list.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download

Dependent Patchsets:

Issue 2873883002 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mpw

3 years, 7 months ago (2017-05-10 15:38:13 UTC) #4

On 2017/05/10 03:12:38, Ryan Hamilton wrote:
> lgtm, but please sanitize the CL description :)

Oops! Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages