Re-land: cc: Examine layers to determine if we're ready to activate.

cc/layers/picture_layer_impl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/picture_layer_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <set>
 #include <utility>
@@ skipping 2343 matching lines @@
   contents_scale = 0.5f;
 
   SetContentsScaleOnBothLayers(contents_scale,
                                device_scale,
                                page_scale,
                                maximum_animation_scale,
                                animating_transform);
   EXPECT_BOTH_EQ(HighResTiling()->contents_scale(), 1.f);
 }
 
+TEST_F(PictureLayerImplTest, AllTilesRequiredForActivationAreReadyToDraw) {

[vmpstr, 2014/05/21 22:28:30]

Can you add a similar test where you first mark all high res as done but not low
res? That's the case where we were activating before (since we skipped low res
in GetTilesWithAssignedBins)

[reveman, 2014/05/22 20:47:49]

Done.

+  gfx::Size tile_size(100, 100);
+  gfx::Size layer_bounds(1000, 1000);
+
+  scoped_refptr<FakePicturePileImpl> pending_pile =
+      FakePicturePileImpl::CreateFilledPile(tile_size, layer_bounds);
+
+  SetupPendingTree(pending_pile);
+  pending_layer_->SetBounds(layer_bounds);
+
+  ASSERT_TRUE(pending_layer_->CanHaveTilings());
+
+  float low_res_factor = host_impl_.settings().low_res_contents_scale_factor;
+
+  pending_layer_->AddTiling(low_res_factor);
+  pending_layer_->AddTiling(0.3f);
+  pending_layer_->AddTiling(0.7f);
+  pending_layer_->AddTiling(1.0f);
+  pending_layer_->AddTiling(2.0f);
+
+  host_impl_.SetViewportSize(gfx::Size(500, 500));
+  host_impl_.pending_tree()->UpdateDrawProperties();
+
+  // Initialize all low-res tiles.
+  for (PictureLayerImpl::LayerRasterTileIterator it(
+           pending_layer_, SAME_PRIORITY_FOR_BOTH_TREES);
+       it;
+       ++it) {
+    Tile* tile = *it;
+    TilePriority priority = tile->priority(PENDING_TREE);
+
+    if (priority.resolution != LOW_RESOLUTION)
+      continue;
+
+    ManagedTileState::TileVersion& tile_version =
+        tile->GetTileVersionForTesting(
+            tile->DetermineRasterModeForTree(PENDING_TREE));
+    tile_version.SetSolidColorForTesting(SK_ColorRED);
+  }
+
+  // Low-res tiles should not be enough.
+  EXPECT_FALSE(pending_layer_->AllTilesRequiredForActivationAreReadyToDraw());
+
+  // Initialize all tiles.
+  for (PictureLayerImpl::LayerRasterTileIterator it(
+           pending_layer_, SAME_PRIORITY_FOR_BOTH_TREES);
+       it;
+       ++it) {
+    Tile* tile = *it;
+
+    ManagedTileState::TileVersion& tile_version =
+        tile->GetTileVersionForTesting(
+            tile->DetermineRasterModeForTree(PENDING_TREE));
+    tile_version.SetSolidColorForTesting(SK_ColorRED);
+  }
+
+  EXPECT_TRUE(pending_layer_->AllTilesRequiredForActivationAreReadyToDraw());
+}
+
 }  // namespace
 }  // namespace cc