chrome/browser/devtools/device/android_device_manager.h - Issue 287643002: DevTools: Partially redesigned DevToolsAndroidBridge and AndroidDeviceManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/android_device_manager.h

Issue 287643002: DevTools: Partially redesigned DevToolsAndroidBridge and AndroidDeviceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Used scoped_ptr. Fixed DeviceHandle destruction Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc ('k') | chrome/browser/devtools/device/android_device_manager.cc » ('j') | chrome/browser/devtools/device/android_device_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/android_device_manager.h

diff --git a/chrome/browser/devtools/device/android_device_manager.h b/chrome/browser/devtools/device/android_device_manager.h

index 27d1be809fa069e1330fe6e33d15bb07e2ef3fd4..888f6d5d6d5a469d6f7466c6a447bb0f2f623ccc 100644

--- a/chrome/browser/devtools/device/android_device_manager.h

+++ b/chrome/browser/devtools/device/android_device_manager.h

@@ -114,7 +114,7 @@ class AndroidDeviceManager

void QueryDevices(const DeviceProviders& providers,

const QueryDevicesCallback& callback);

- void Stop();

+ void ReleaseDevice(const std::string& serial);

bool IsConnected(const std::string& serial);

@@ -152,8 +152,6 @@ class AndroidDeviceManager

typedef std::map<std::string, scoped_refptr<Device> > DeviceMap;

DeviceMap devices_;

- bool stopped_;

};

#endif // CHROME_BROWSER_DEVTOOLS_DEVICE_ANDROID_DEVICE_MANAGER_H_