Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3166)

Unified Diff: chrome/browser/devtools/device/adb/mock_adb_server.cc

Issue 287643002: DevTools: Partially redesigned DevToolsAndroidBridge and AndroidDeviceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved Device::OpenSocket callback to HandlerThread Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/adb/mock_adb_server.cc
diff --git a/chrome/browser/devtools/device/adb/mock_adb_server.cc b/chrome/browser/devtools/device/adb/mock_adb_server.cc
index e528729bff8784803b9469aa662caec77144fd47..96b52abb94f0d64ef19f7ff4260634e4eb38b855 100644
--- a/chrome/browser/devtools/device/adb/mock_adb_server.cc
+++ b/chrome/browser/devtools/device/adb/mock_adb_server.cc
@@ -463,7 +463,7 @@ class MockAdbServer : SingleConnectionServer::Parser,
selected_device_ = command.substr(strlen(kHostTransportPrefix));
SendResponse("");
} else if (selected_device_ != kSerialOnline) {
- NOTREACHED() << "Unknown device - " << selected_device_;
+ Send("FAIL", "device offline (x)");
} else if (command == kDeviceModelCommand) {
SendResponse(kDeviceModel);
} else if (command == kOpenedUnixSocketsCommand) {
@@ -480,10 +480,14 @@ class MockAdbServer : SingleConnectionServer::Parser,
}
}
- void SendResponse(const std::string& response) {
+ void SendResponse(const std::string& response) { Send("OKAY", response); }
+
+ void Send(const std::string& status, const std::string& response) {
CHECK(CalledOnValidThread());
+ CHECK_EQ(4U, status.size());
+
std::stringstream response_stream;
- response_stream << "OKAY";
+ response_stream << status;
int size = response.size();
if (size > 0) {
« no previous file with comments | « chrome/browser/devtools/device/adb/adb_device_provider.cc ('k') | chrome/browser/devtools/device/android_device_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698