Generate diffing functions for generated subgroup BoxData in ComputedStyle

third_party/WebKit/Source/core/style/ComputedStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 540 matching lines @@
 
   return diff;
 }
 
 bool ComputedStyle::ScrollAnchorDisablingPropertyChanged(
     const ComputedStyle& other,
     const StyleDifference& diff) const {
   if (GetPosition() != other.GetPosition())
     return true;
 
-  if (box_data_.Get() != other.box_data_.Get()) {
-    if (box_data_->width_ != other.box_data_->width_ ||
-        box_data_->min_width_ != other.box_data_->min_width_ ||
-        box_data_->max_width_ != other.box_data_->max_width_ ||
-        box_data_->height_ != other.box_data_->height_ ||
-        box_data_->min_height_ != other.box_data_->min_height_ ||
-        box_data_->max_height_ != other.box_data_->max_height_)
-      return true;
-  }
-
   if (ComputedStyleBase::ScrollAnchorDisablingPropertyChanged(other))
     return true;
 
   if (diff.TransformChanged())
     return true;
 
   return false;
 }
 
 bool ComputedStyle::DiffNeedsFullLayoutAndPaintInvalidation(
@@ skipping 229 matching lines @@
       other.HasPseudoStyle(kPseudoIdScrollbar))
     return true;
 
   // Movement of non-static-positioned object is special cased in
   // ComputedStyle::VisualInvalidationDiff().
 
   return false;
 }
 
 bool ComputedStyle::DiffNeedsFullLayout(const ComputedStyle& other) const {
+  if (ComputedStyleBase::DiffNeedsFullLayout(other))
+    return true;
+
   if (box_data_.Get() != other.box_data_.Get()) {
-    if (box_data_->width_ != other.box_data_->width_ ||

[shend, 2017/05/15 01:40:22]

Hmm, why do the generated code have a different order?

[nainar, 2017/05/15 01:53:30]

This is because the order is determined by the order in which they are stored on
the group. Ordering shouldn't matter.

-        box_data_->min_width_ != other.box_data_->min_width_ ||
-        box_data_->max_width_ != other.box_data_->max_width_ ||
-        box_data_->height_ != other.box_data_->height_ ||
-        box_data_->min_height_ != other.box_data_->min_height_ ||
-        box_data_->max_height_ != other.box_data_->max_height_)
-      return true;
-
     if (box_data_->vertical_align_length_ !=
         other.box_data_->vertical_align_length_)
       return true;
-
-    if (box_data_->box_sizing_ != other.box_data_->box_sizing_)
-      return true;
   }
 
   if (VerticalAlign() != other.VerticalAlign() ||
       GetPosition() != other.GetPosition())
     return true;
 
   if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
     if (rare_non_inherited_data_->align_content_ !=
             other.rare_non_inherited_data_->align_content_ ||
         rare_non_inherited_data_->align_items_ !=
@@ skipping 1673 matching lines @@
     if (value < 0)
       fvalue -= 0.5f;
     else
       fvalue += 0.5f;
   }
 
   return RoundForImpreciseConversion<int>(fvalue / zoom_factor);
 }
 
 }  // namespace blink