Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5867)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 2876223003: cocoa: add some tab-manipulation menu items (Closed)
Patch Set: unstage nib delta Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index e917e1714c823428dc008522b8c9da25e9a191f0..cef93e60e293a39afbe40f3455211676932cbb48 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -646,6 +646,13 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
RouteMedia(browser_);
break;
Robert Sesek 2017/05/16 19:47:41 nit: remove blank line (not present between other
Elly Fong-Jones 2017/05/17 17:56:16 Done.
+ case IDC_WINDOW_MUTE_TAB:
+ MuteTab(browser_);
+ break;
+ case IDC_WINDOW_PIN_TAB:
+ PinTab(browser_);
+ break;
+
default:
LOG(WARNING) << "Received Unimplemented Command: " << id;
break;
@@ -843,6 +850,9 @@ void BrowserCommandController::InitCommandState() {
IDC_DISTILL_PAGE, base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableDomDistiller));
+ command_updater_.UpdateCommandEnabled(IDC_WINDOW_MUTE_TAB, normal_window);
+ command_updater_.UpdateCommandEnabled(IDC_WINDOW_PIN_TAB, normal_window);
+
// Initialize other commands whose state changes based on various conditions.
UpdateCommandsForFullscreenMode();
UpdateCommandsForContentRestrictionState();
@@ -918,6 +928,10 @@ void BrowserCommandController::UpdateCommandsForTabState() {
// Window management commands
command_updater_.UpdateCommandEnabled(IDC_DUPLICATE_TAB,
!browser_->is_app() && CanDuplicateTab(browser_));
+ command_updater_.UpdateCommandEnabled(IDC_WINDOW_MUTE_TAB,
+ !browser_->is_app());
+ command_updater_.UpdateCommandEnabled(IDC_WINDOW_PIN_TAB,
+ !browser_->is_app());
// Page-related commands
window()->SetStarredState(

Powered by Google App Engine
This is Rietveld 408576698