Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: ui/views/controls/menu/menu_runner.h

Issue 2876203003: Make shelf item can be dragged when context menu is opened.
Patch Set: rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/menu/menu_runner.h
diff --git a/ui/views/controls/menu/menu_runner.h b/ui/views/controls/menu/menu_runner.h
index abba98e9dd4095862b385ff57b26a6b49f3e2789..07c8c63321a38ed1703e07be108f8c4f8bd6259b 100644
--- a/ui/views/controls/menu/menu_runner.h
+++ b/ui/views/controls/menu/menu_runner.h
@@ -89,6 +89,12 @@ class VIEWS_EXPORT MenuRunner {
// Menu with fixed anchor position, so |MenuRunner| will not attempt to
// adjust the anchor point. For example the context menu of shelf item.
FIXED_ANCHOR = 1 << 6,
+
+ // Owner of the menu could be in the middle of a gesture when the menu opens
msw 2017/06/01 20:24:28 nit: "The menu's owner could"
minch1 2017/06/23 23:13:03 Done.
+ // and can use this flag to continue the gesture. For example, shelf uses
msw 2017/06/01 20:24:28 nit: "Chrome OS's shelf"
minch1 2017/06/23 23:13:03 Done.
+ // the flag to continue dragging an item without lifting the finger after
+ // the context menu of the item is opened.
+ PRESERVE_CURRENT_GESTURE_FOR_OWNER = 1 << 7,
msw 2017/06/01 20:24:28 optional nit: keep name in sync with MenuControlle
minch1 2017/06/23 23:13:03 Done.
};
// Creates a new MenuRunner, which may use a native menu if available.

Powered by Google App Engine
This is Rietveld 408576698