Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: ui/views/controls/menu/menu_runner.h

Issue 2876203003: Make shelf item can be dragged when context menu is opened.
Patch Set: Rebased and renamed. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_H_ 5 #ifndef UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_H_
6 #define UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_H_ 6 #define UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 82
83 // A child view is performing a drag-and-drop operation, so the menu should 83 // A child view is performing a drag-and-drop operation, so the menu should
84 // stay open (even if it doesn't receive drag updated events). In this case, 84 // stay open (even if it doesn't receive drag updated events). In this case,
85 // the caller is responsible for closing the menu upon completion of the 85 // the caller is responsible for closing the menu upon completion of the
86 // drag-and-drop. 86 // drag-and-drop.
87 NESTED_DRAG = 1 << 5, 87 NESTED_DRAG = 1 << 5,
88 88
89 // Menu with fixed anchor position, so |MenuRunner| will not attempt to 89 // Menu with fixed anchor position, so |MenuRunner| will not attempt to
90 // adjust the anchor point. For example the context menu of shelf item. 90 // adjust the anchor point. For example the context menu of shelf item.
91 FIXED_ANCHOR = 1 << 6, 91 FIXED_ANCHOR = 1 << 6,
92
93 // Owner of the menu can be dragged after menu is created and dragging will
94 // close the menu. For example the shelf item can be dragged when the
95 // context menu of the item is opened.
xiyuan 2017/05/26 23:13:38 nit: I would say something like // Owner of the m
minch1 2017/06/01 16:42:28 Done.
96 PRESERVE_CURRENT_GESTURE_FOR_OWNER = 1 << 7,
92 }; 97 };
93 98
94 // Creates a new MenuRunner, which may use a native menu if available. 99 // Creates a new MenuRunner, which may use a native menu if available.
95 // |run_types| is a bitmask of RunTypes. If provided, 100 // |run_types| is a bitmask of RunTypes. If provided,
96 // |on_menu_closed_callback| is invoked when the menu is closed. 101 // |on_menu_closed_callback| is invoked when the menu is closed.
97 // Note that with a native menu (e.g. on Mac), the ASYNC flag in |run_types| 102 // Note that with a native menu (e.g. on Mac), the ASYNC flag in |run_types|
98 // may be ignored. See http://crbug.com/682544. 103 // may be ignored. See http://crbug.com/682544.
99 MenuRunner(ui::MenuModel* menu_model, 104 MenuRunner(ui::MenuModel* menu_model,
100 int32_t run_types, 105 int32_t run_types,
101 const base::Closure& on_menu_closed_callback = base::Closure()); 106 const base::Closure& on_menu_closed_callback = base::Closure());
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 163
159 protected: 164 protected:
160 DisplayChangeListener() {} 165 DisplayChangeListener() {}
161 }; 166 };
162 167
163 } // namespace internal 168 } // namespace internal
164 169
165 } // namespace views 170 } // namespace views
166 171
167 #endif // UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_H_ 172 #endif // UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698