Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: content/public/test/browser_test_base.cc

Issue 2876153002: Support Using ScopedFeatureList in BrowserTest (Closed)
Patch Set: ilya comments addressed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/browser_test_base.cc
diff --git a/content/public/test/browser_test_base.cc b/content/public/test/browser_test_base.cc
index e956f2d6b0c002423d133e1a82675f7991768319..402de98170218de6077306bc6af4c6ed8dfdcd44 100644
--- a/content/public/test/browser_test_base.cc
+++ b/content/public/test/browser_test_base.cc
@@ -230,6 +230,11 @@ void BrowserTestBase::SetUp() {
SetUpInProcessBrowserTestFixture();
+ DCHECK(!command_line->HasSwitch(switches::kEnableFeatures))
+ << "Should not use CommandLine to modify features.";
Ilya Sherman 2017/06/13 22:42:48 Please list this as a comment if you'd like to inc
chaopeng 2017/06/28 14:16:51 Done.
+ DCHECK(!command_line->HasSwitch(switches::kDisableFeatures))
+ << "Should not use CommandLine to modify features.";
+
// At this point, copy features to the command line, since BrowserMain will
// wipe out the current feature list.
std::string enabled_features;

Powered by Google App Engine
This is Rietveld 408576698