Support Using ScopedFeatureList in BrowserTest

chrome/browser/net/predictor.cc

Index: chrome/browser/net/predictor.cc
diff --git a/chrome/browser/net/predictor.cc b/chrome/browser/net/predictor.cc
index 566818448a5ca13bba5baa48e56c8e0ad055ca52..5fe898ad8118e5b1ee56738879501e5b5553a44a 100644
--- a/chrome/browser/net/predictor.cc
+++ b/chrome/browser/net/predictor.cc
@@ -15,7 +15,6 @@
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/containers/mru_cache.h"
-#include "base/feature_list.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/macros.h"
@@ -53,14 +52,14 @@
 using base::TimeDelta;
 using content::BrowserThread;
 
-namespace chrome_browser_net {
-
-namespace {
+namespace features {
 
 const base::Feature kNetworkPrediction{"NetworkPrediction",
                                        base::FEATURE_ENABLED_BY_DEFAULT};
 
-}  // namespace
+}  // namespace features

[Ilya Sherman, 2017/06/09 20:19:28]

Why did you move this out of the chrome_browser_net namespace?  Should this
actually be defined in
https://cs.chromium.org/chromium/src/chrome/common/chrome_features.h ?

+
+namespace chrome_browser_net {
 
 // static
 const int Predictor::kPredictorReferrerVersion = 2;
@@ -128,7 +127,8 @@ Predictor::~Predictor() {
 
 // static
 Predictor* Predictor::CreatePredictor(bool simple_shutdown) {
-  bool predictor_enabled = base::FeatureList::IsEnabled(kNetworkPrediction);
+  bool predictor_enabled =
+      base::FeatureList::IsEnabled(features::kNetworkPrediction);
   if (simple_shutdown)
     return new SimplePredictor(predictor_enabled);
   return new Predictor(predictor_enabled);