Support Using ScopedFeatureList in BrowserTest

content/test/content_browser_test_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/content_browser_test.h"
 
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/process/launch.h"
 #include "base/single_thread_task_runner.h"
+#include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/launcher/test_launcher.h"
+#include "base/test/scoped_feature_list.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_process_host_observer.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_launcher.h"
@@ skipping 148 matching lines @@
 IN_PROC_BROWSER_TEST_F(ContentBrowserTestSanityTest, Basic) {
   Test();
 }
 
 IN_PROC_BROWSER_TEST_F(ContentBrowserTestSanityTest, SingleProcess) {
   Test();
 }
 
 namespace {
 
+const base::Feature kTestFeatureForContentBrowserTest{

[Ilya Sherman, 2017/06/09 20:19:28]

nit: Please add an extra space before the curly brace.

+    "TestFeatureForContentBrowserTest", base::FEATURE_DISABLED_BY_DEFAULT};
+
+}  // namespace
+
+class ContentBrowserTestScopedFeatureListTest : public ContentBrowserTest {
+ public:
+  void SetUp() override {
+    std::string disabled_features;
+    base::FeatureList::GetInstance()->GetFeatureOverrides(&enabled_features_,
+                                                          &disabled_features);
+    ContentBrowserTest::SetUp();
+  }
+
+  std::string enabled_features_;
+
+ private:
+  base::test::ScopedFeatureList scoped_feature_list_;
+};
+
+IN_PROC_BROWSER_TEST_F(ContentBrowserTestScopedFeatureListTest,
+                       FeatureListTest) {
+  std::string enabled_features0;
+  std::string disabled_features0;
+
+  base::FeatureList::GetInstance()->GetFeatureOverrides(&enabled_features0,
+                                                        &disabled_features0);
+
+  base::StringPiece enabled_features = enabled_features0;
+
+  // Ensure we repected the features from command line.
+  std::vector<base::StringPiece> original_enabled_features =
+      base::SplitStringPiece(enabled_features_, ",", base::TRIM_WHITESPACE,
+                             base::SPLIT_WANT_NONEMPTY);
+
+  for (base::StringPiece enabled_feature : original_enabled_features) {
+    EXPECT_NE(enabled_features.find(enabled_feature), base::StringPiece::npos);
+  }
+
+  // Ensure kTestFeatureForContentBrowserTest enabled.
+  EXPECT_TRUE(base::FeatureList::IsEnabled(kTestFeatureForContentBrowserTest));

[Ilya Sherman, 2017/06/09 20:19:28]

I don't understand.  Where is the feature being enabled?

[chaopeng, 2017/06/13 04:16:32]

Sorry, Forgot to test it before send to you.

+}
+
+namespace {
+
 void CallbackChecker(bool* non_nested_task_ran) {
   *non_nested_task_ran = true;
 }
 
 }  // namespace
 
 IN_PROC_BROWSER_TEST_F(ContentBrowserTest, NonNestableTask) {
   bool non_nested_task_ran = false;
   base::ThreadTaskRunnerHandle::Get()->PostNonNestableTask(
       FROM_HERE, base::Bind(&CallbackChecker, &non_nested_task_ran));
   content::RunAllPendingInMessageLoop();
   ASSERT_TRUE(non_nested_task_ran);
 }
 
 }  // namespace content