Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 287613002: Fill |model_name| and |vendor_name| fields of StorageInfo for MTP devices. (Closed)

Created:
6 years, 7 months ago by kinaba
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Fill |model_name| and |vendor_name| fields of StorageInfo for MTP devices. BUG=370692 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270053

Patch Set 1 #

Total comments: 2

Patch Set 2 : Test for the newly filled members. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M components/storage_monitor/media_transfer_protocol_device_observer_linux.h View 1 chunk +4 lines, -2 lines 0 comments Download
M components/storage_monitor/media_transfer_protocol_device_observer_linux.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc View 1 4 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
PTAL.
6 years, 7 months ago (2014-05-13 05:20:44 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/287613002/diff/1/components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc File components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc (right): https://codereview.chromium.org/287613002/diff/1/components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc#newcode56 components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc:56: vendor_name->clear(); maybe add a fake vendor / product ...
6 years, 7 months ago (2014-05-13 06:19:51 UTC) #2
kinaba
https://codereview.chromium.org/287613002/diff/1/components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc File components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc (right): https://codereview.chromium.org/287613002/diff/1/components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc#newcode56 components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc:56: vendor_name->clear(); On 2014/05/13 06:19:51, Lei Zhang wrote: > maybe ...
6 years, 7 months ago (2014-05-13 06:29:31 UTC) #3
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-13 06:39:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/287613002/20001
6 years, 7 months ago (2014-05-13 06:39:27 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 08:37:56 UTC) #6
Message was sent while issue was closed.
Change committed as 270053

Powered by Google App Engine
This is Rietveld 408576698