Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2876113002: [MD Bookmarks] Scroll selected folder into view in sidebar. (Closed)

Created:
3 years, 7 months ago by calamity
Modified:
3 years, 7 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Scroll selected folder into view in sidebar. BUG=721649 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2876113002 Cr-Commit-Position: refs/heads/master@{#471647} Committed: https://chromium.googlesource.com/chromium/src/+/ff308e070f61164178200816832dc00a974f8430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/resources/md_bookmarks/folder_node.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
calamity
3 years, 7 months ago (2017-05-12 06:10:33 UTC) #3
tsergeant
lgtm
3 years, 7 months ago (2017-05-12 06:28:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876113002/1
3 years, 7 months ago (2017-05-12 06:36:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/292240)
3 years, 7 months ago (2017-05-12 08:28:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876113002/1
3 years, 7 months ago (2017-05-15 00:19:47 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 01:24:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff308e070f61164178200816832d...

Powered by Google App Engine
This is Rietveld 408576698