Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: tools/perf/benchmarks/loading.py

Issue 2876073003: Migrate cluster telemetry benchmarks to tools/perf/contrib/cluster_telemetry/ (Closed)
Patch Set: Remove BENCHMARKS_BLACK_LIST Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/loading.py
diff --git a/tools/perf/benchmarks/loading.py b/tools/perf/benchmarks/loading.py
index ed570a575f90ce05ddf7d978c2ad9727070b9d0e..7c9540ae70e8257f2da4f239baed354a53d357cf 100644
--- a/tools/perf/benchmarks/loading.py
+++ b/tools/perf/benchmarks/loading.py
@@ -5,7 +5,6 @@
from core import perf_benchmark
import page_sets
-import ct_benchmarks_util
from benchmarks import page_cycler_v2
from telemetry import benchmark
from telemetry.page import cache_temperature
@@ -70,38 +69,3 @@ class LoadingMobile(_LoadingBase):
@classmethod
def Name(cls):
return 'loading.mobile'
-
-
-# Disabled because we do not plan on running CT benchmarks on the perf
-# waterfall any time soon.
-@benchmark.Disabled('all')
-class LoadingClusterTelemetry(_LoadingBase):
-
- options = {'upload_results': True}
-
- _ALL_NET_CONFIGS = traffic_setting.NETWORK_CONFIGS.keys()
-
- @classmethod
- def AddBenchmarkCommandLineArgs(cls, parser):
- super(LoadingClusterTelemetry, cls).AddBenchmarkCommandLineArgs(parser)
- ct_benchmarks_util.AddBenchmarkCommandLineArgs(parser)
- parser.add_option(
- '--wait-time', action='store', type='int',
- default=60, help='Number of seconds to wait for after navigation.')
- parser.add_option(
- '--traffic-setting', choices=cls._ALL_NET_CONFIGS,
- default=traffic_setting.REGULAR_4G,
- help='Traffic condition (string). Default to "%%default". Can be: %s' %
- ', '.join(cls._ALL_NET_CONFIGS))
-
- def CreateStorySet(self, options):
- def Wait(action_runner):
- action_runner.Wait(options.wait_time)
- return page_sets.CTPageSet(
- options.urls_list, options.user_agent, options.archive_data_file,
- traffic_setting=options.traffic_setting,
- run_page_interaction_callback=Wait)
-
- @classmethod
- def Name(cls):
- return 'loading.cluster_telemetry'

Powered by Google App Engine
This is Rietveld 408576698