Create _prebuild projects for targets with rules/actions

Effectively duplicates targets that contain rules/actions, therefore enabling correct dependency processing on windows.

This patch mimics the changes for XCode.

[bradn, 2010-07-02 21:26:22]

LGTM

[jochen, 2010-07-02 23:23:29]

the patch works on my local box. I submitted a tryjob to the win bot, but since
it's 1:30am now, it's enough for today.

[M-A Ruel, 2010-07-03 14:04:55]

btw it's awesome and simple, thanks!

http://codereview.chromium.org/2876041/diff/11001/12001
File pylib/gyp/generator/msvs.py (right):

http://codereview.chromium.org/2876041/diff/11001/12001#newcode1183
pylib/gyp/generator/msvs.py:1183: target_dicts[new_target] =
deepcopy(target_dicts[qualified_target])
I'd like it to check if new_target in target_dicts: first to detect inadvertent
override.

Also, shouldn't it copy include_dirs too? I guess all actions/rules don't use it
so it may be best to leave it out. I'm mostly wondering about idl processing
which have a concept of include dir, I don't know about the other rules/actions.

[M-A Ruel, 2010-07-03 14:07:09]

Another question; is this only needed when process_outputs_as_sources is
defined? Is process_outputs_as_sources still useful at all after this change,
especially with the XCode change and the fact it's probably unnecessary for
make/SCons?

[M-A Ruel, 2010-07-03 14:07:24]

And lastly, a unit test? :D

[jochen, 2010-07-03 14:25:14]

On 2010/07/03 14:04:55, Marc-Antoine Ruel wrote:
> btw it's awesome and simple, thanks!
> 
> http://codereview.chromium.org/2876041/diff/11001/12001
> File pylib/gyp/generator/msvs.py (right):
> 
> http://codereview.chromium.org/2876041/diff/11001/12001#newcode1183
> pylib/gyp/generator/msvs.py:1183: target_dicts[new_target] =
> deepcopy(target_dicts[qualified_target])
> I'd like it to check if new_target in target_dicts: first to detect
inadvertent
> override.
> 
> Also, shouldn't it copy include_dirs too? I guess all actions/rules don't use
it
> so it may be best to leave it out. I'm mostly wondering about idl processing
> which have a concept of include dir, I don't know about the other
rules/actions.

include_dirs is included in target_dirs[qualified_target]['configurations']

[jochen, 2010-07-03 14:26:35]

On 2010/07/03 14:07:09, Marc-Antoine Ruel wrote:
> Another question; is this only needed when process_outputs_as_sources is
> defined? Is process_outputs_as_sources still useful at all after this change,
> especially with the XCode change and the fact it's probably unnecessary for
> make/SCons?

I don't know about make/scons. I think for xcode and msvs it would be enough to
only copy those targets where at least a rule or action has
process_outputs_as_sources set. However, since the xcode generator went down
this path I thought it would be good to do the same for msvs.

[jochen, 2010-07-03 14:26:52]

On 2010/07/03 14:07:24, Marc-Antoine Ruel wrote:
> And lastly, a unit test? :D

in which directory should i put it?

[M-A Ruel, 2010-07-03 14:38:55]

On 2010/07/03 14:26:52, jochen wrote:
> On 2010/07/03 14:07:24, Marc-Antoine Ruel wrote:
> > And lastly, a unit test? :D
> 
> in which directory should i put it?

I don't know. Others can help there.

On 2010/07/03 14:26:35, jochen wrote:
> On 2010/07/03 14:07:09, Marc-Antoine Ruel wrote:
> > Another question; is this only needed when process_outputs_as_sources is
> > defined? Is process_outputs_as_sources still useful at all after this
change,
> > especially with the XCode change and the fact it's probably unnecessary for
> > make/SCons?
> 
> I don't know about make/scons. I think for xcode and msvs it would be enough
to
> only copy those targets where at least a rule or action has
> process_outputs_as_sources set. However, since the xcode generator went down
> this path I thought it would be good to do the same for msvs.

It's fine with me.

[jochen, 2010-07-03 17:01:50]

On 2010/07/03 14:38:55, Marc-Antoine Ruel wrote:
> On 2010/07/03 14:26:52, jochen wrote:
> > On 2010/07/03 14:07:24, Marc-Antoine Ruel wrote:
> > > And lastly, a unit test? :D
> > 
> > in which directory should i put it?
> 
> I don't know. Others can help there.
> 
> On 2010/07/03 14:26:35, jochen wrote:
> > On 2010/07/03 14:07:09, Marc-Antoine Ruel wrote:
> > > Another question; is this only needed when process_outputs_as_sources is
> > > defined? Is process_outputs_as_sources still useful at all after this
> change,
> > > especially with the XCode change and the fact it's probably unnecessary
for
> > > make/SCons?
> > 
> > I don't know about make/scons. I think for xcode and msvs it would be enough
> to
> > only copy those targets where at least a rule or action has
> > process_outputs_as_sources set. However, since the xcode generator went down
> > this path I thought it would be good to do the same for msvs.
> 
> It's fine with me.

I've created http://codereview.chromium.org/2866042 to get trybot results in