Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2693)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 2876033005: Track slow paths in DisplayItemList (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
index 36b7ca84fb5b8981d55c5a43a3d30ce55d198bda..f339367150f6dd244bb20f637a784ea35aa6d415 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
@@ -16,8 +16,6 @@
#include <stdio.h>
#endif
-static constexpr int kMaxNumberOfSlowPathsBeforeVeto = 5;
-
namespace blink {
void PaintController::SetTracksRasterInvalidations(bool value) {
@@ -574,9 +572,7 @@ void PaintController::CommitNewDisplayItems(
Vector<const DisplayItemClient*> skipped_cache_clients;
for (const auto& item : new_display_item_list_) {
- // No reason to continue the analysis once we have a veto.
- if (num_slow_paths <= kMaxNumberOfSlowPathsBeforeVeto)
- num_slow_paths += item.NumberOfSlowPaths();
+ num_slow_paths += item.NumberOfSlowPaths();
chrishtr 2017/05/13 01:12:04 Why remove the early-out?
enne (OOO) 2017/05/13 18:27:40 Because number of slow paths is a member accessor
// TODO(wkorman): Only compute and append visual rect for drawings.
new_display_item_list_.AppendVisualRect(
@@ -617,9 +613,9 @@ void PaintController::CommitNewDisplayItems(
for (const auto& chunk : current_paint_artifact_.PaintChunks())
raster_invalidation_tracking_info_->map.Remove(&chunk);
}
- current_paint_artifact_ = PaintArtifact(
- std::move(new_display_item_list_), new_paint_chunks_.ReleasePaintChunks(),
- num_slow_paths <= kMaxNumberOfSlowPathsBeforeVeto);
+ current_paint_artifact_ =
+ PaintArtifact(std::move(new_display_item_list_),
+ new_paint_chunks_.ReleasePaintChunks(), num_slow_paths);
ResetCurrentListIndices();
out_of_order_item_indices_.clear();

Powered by Google App Engine
This is Rietveld 408576698