Track slow paths in DisplayItemList

third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/paint/PaintController.h"
 
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/paint/ClipPathDisplayItem.h"
 #include "platform/graphics/paint/ClipPathRecorder.h"
@@ skipping 1906 matching lines @@
   flags.setAntiAlias(true);
   for (unsigned i = 0; i < count; i++)
     context.DrawPath(path, flags);
 }
 
 TEST_F(PaintControllerTestBase, IsSuitableForGpuRasterizationSinglePath) {
   FakeDisplayItemClient client("test client", LayoutRect(0, 0, 200, 100));
   GraphicsContext context(GetPaintController());
   DrawPath(context, client, kBackgroundDrawingType, 1);
   GetPaintController().CommitNewDisplayItems(LayoutSize());
-  EXPECT_TRUE(
-      GetPaintController().GetPaintArtifact().IsSuitableForGpuRasterization());
+  EXPECT_EQ(GetPaintController().GetPaintArtifact().NumSlowPaths(), 1);

[danakj, 2017/05/31 18:03:38]

These EXPECT_EQ's are backwards, expected first

 }
 
 TEST_F(PaintControllerTestBase,
        IsNotSuitableForGpuRasterizationSinglePaintRecordManyPaths) {
   FakeDisplayItemClient client("test client", LayoutRect(0, 0, 200, 100));
   GraphicsContext context(GetPaintController());
 
   DrawPath(context, client, kBackgroundDrawingType, 50);
   GetPaintController().CommitNewDisplayItems(LayoutSize());
-  EXPECT_FALSE(
-      GetPaintController().GetPaintArtifact().IsSuitableForGpuRasterization());
+  EXPECT_EQ(GetPaintController().GetPaintArtifact().NumSlowPaths(), 50);
 }
 
 TEST_F(PaintControllerTestBase,
        IsNotSuitableForGpuRasterizationMultiplePaintRecordsSinglePathEach) {
   FakeDisplayItemClient client("test client", LayoutRect(0, 0, 200, 100));
   GraphicsContext context(GetPaintController());
   GetPaintController().BeginSkippingCache();
 
   for (int i = 0; i < 50; ++i)
     DrawPath(context, client, kBackgroundDrawingType, 50);
 
   GetPaintController().EndSkippingCache();
   GetPaintController().CommitNewDisplayItems(LayoutSize());
-  EXPECT_FALSE(
-      GetPaintController().GetPaintArtifact().IsSuitableForGpuRasterization());
+  EXPECT_EQ(GetPaintController().GetPaintArtifact().NumSlowPaths(), 50 * 50);
 }
 
 TEST_F(PaintControllerTestBase,
        IsNotSuitableForGpuRasterizationSinglePaintRecordManyPathsTwoPaints) {
   FakeDisplayItemClient client("test client", LayoutRect(0, 0, 200, 100));
 
   {
     GraphicsContext context(GetPaintController());
     DrawPath(context, client, kBackgroundDrawingType, 50);
     GetPaintController().CommitNewDisplayItems(LayoutSize());
-    EXPECT_FALSE(GetPaintController()
-                     .GetPaintArtifact()
-                     .IsSuitableForGpuRasterization());
+    EXPECT_EQ(GetPaintController().GetPaintArtifact().NumSlowPaths(), 50);
   }
 
   client.SetDisplayItemsUncached();
 
   {
     GraphicsContext context(GetPaintController());
     DrawPath(context, client, kBackgroundDrawingType, 50);
     GetPaintController().CommitNewDisplayItems(LayoutSize());
-    EXPECT_FALSE(GetPaintController()
-                     .GetPaintArtifact()
-                     .IsSuitableForGpuRasterization());
+    EXPECT_EQ(GetPaintController().GetPaintArtifact().NumSlowPaths(), 50);
   }
 }
 
 TEST_F(PaintControllerTestBase,
        IsNotSuitableForGpuRasterizationSinglePaintRecordManyPathsCached) {
   FakeDisplayItemClient client("test client", LayoutRect(0, 0, 200, 100));
 
   {
     GraphicsContext context(GetPaintController());
     DrawPath(context, client, kBackgroundDrawingType, 50);
     GetPaintController().CommitNewDisplayItems(LayoutSize());
-    EXPECT_FALSE(GetPaintController()
-                     .GetPaintArtifact()
-                     .IsSuitableForGpuRasterization());
+    EXPECT_EQ(GetPaintController().GetPaintArtifact().NumSlowPaths(), 50);
   }
 
   {
     GraphicsContext context(GetPaintController());
     DrawPath(context, client, kBackgroundDrawingType, 50);
     GetPaintController().CommitNewDisplayItems(LayoutSize());
-    EXPECT_FALSE(GetPaintController()
-                     .GetPaintArtifact()
-                     .IsSuitableForGpuRasterization());
+    EXPECT_EQ(GetPaintController().GetPaintArtifact().NumSlowPaths(), 50);
   }
 }
 
 TEST_F(
     PaintControllerTestBase,
     IsNotSuitableForGpuRasterizationSinglePaintRecordManyPathsCachedSubsequence) {
   FakeDisplayItemClient client("test client", LayoutRect(0, 0, 200, 100));
   FakeDisplayItemClient container("container", LayoutRect(0, 0, 200, 100));
 
   GraphicsContext context(GetPaintController());
   {
     SubsequenceRecorder subsequence_recorder(context, container);
     DrawPath(context, client, kBackgroundDrawingType, 50);
   }
   GetPaintController().CommitNewDisplayItems(LayoutSize());
-  EXPECT_FALSE(
-      GetPaintController().GetPaintArtifact().IsSuitableForGpuRasterization());
+  EXPECT_EQ(GetPaintController().GetPaintArtifact().NumSlowPaths(), 50);
 
   EXPECT_TRUE(
       SubsequenceRecorder::UseCachedSubsequenceIfPossible(context, container));
   GetPaintController().CommitNewDisplayItems(LayoutSize());
-  EXPECT_FALSE(
-      GetPaintController().GetPaintArtifact().IsSuitableForGpuRasterization());
+  EXPECT_EQ(GetPaintController().GetPaintArtifact().NumSlowPaths(), 50);
 
 #if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
   DisplayItemClient::EndShouldKeepAliveAllClients();
 #endif
 }
 
 // Temporarily disabled (pref regressions due to GPU veto stickiness:
 // http://crbug.com/603969).
 TEST_F(PaintControllerTestBase,
        DISABLED_IsNotSuitableForGpuRasterizationConcaveClipPath) {
   Path path;
   path.AddLineTo(FloatPoint(50, 50));
   path.AddLineTo(FloatPoint(100, 0));
   path.AddLineTo(FloatPoint(50, 100));
   path.CloseSubpath();
 
   FakeDisplayItemClient client("test client", LayoutRect(0, 0, 200, 100));
   GraphicsContext context(GetPaintController());
 
   // Run twice for empty/non-empty m_currentPaintArtifact coverage.
   for (int i = 0; i < 2; ++i) {
     for (int j = 0; j < 50; ++j)
       GetPaintController().CreateAndAppend<BeginClipPathDisplayItem>(client,
                                                                      path);
     DrawRect(context, client, kBackgroundDrawingType,
              FloatRect(0, 0, 100, 100));
     for (int j = 0; j < 50; ++j)
       GetPaintController().CreateAndAppend<EndClipPathDisplayItem>(client);
     GetPaintController().CommitNewDisplayItems(LayoutSize());
-    EXPECT_FALSE(GetPaintController()
-                     .GetPaintArtifact()
-                     .IsSuitableForGpuRasterization());
+    EXPECT_EQ(GetPaintController().GetPaintArtifact().NumSlowPaths(), 50 * i);
   }
 }
 
 TEST_F(PaintControllerTestBase, BeginAndEndFrame) {
   class FakeFrame {};
 
   // PaintController should have one null frame in the stack since beginning.
   GetPaintController().SetFirstPainted();
   FrameFirstPaint result = GetPaintController().EndFrame(nullptr);
   EXPECT_TRUE(result.first_painted);
@@ skipping 295 matching lines @@
 TEST_F(PaintControllerUnderInvalidationTest, InvalidationInSubsequence) {
   // We allow invalidated display item clients as long as they would produce the
   // same display items. The cases of changed display items are tested by other
   // test cases.
   TestInvalidationInSubsequence();
 }
 
 #endif  // defined(GTEST_HAS_DEATH_TEST) && !OS(ANDROID)
 
 }  // namespace blink