Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2876023003: Allow the common spec types to be in a separate document (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow the common spec types to be in a separate document R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/2cbcd963274fc77f599731e089b6ec9c55e087c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2963 lines, -2840 lines) Patch
M pkg/analyzer_plugin/doc/api.html View 8 chunks +24 lines, -44 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart View 4 chunks +20 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart View 2 chunks +925 lines, -921 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_matchers.dart View 1 chunk +4 lines, -1 line 0 comments Download
A pkg/analyzer_plugin/tool/spec/common_types_spec.html View 1 chunk +1357 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/from_html.dart View 1 chunk +539 lines, -502 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/plugin_spec.html View 3 chunks +86 lines, -1369 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/to_html.dart View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This allows us to split the common types into a separate file. It doesn't change ...
3 years, 7 months ago (2017-05-12 18:57:54 UTC) #2
danrubel
LGTM
3 years, 7 months ago (2017-05-12 19:03:31 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-12 19:24:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2cbcd963274fc77f599731e089b6ec9c55e087c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698