Issue 2876023002: Use VrTabHelper to disable popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2876023002: Use VrTabHelper to disable popups

Created:
3 years, 7 months ago by asimjour1

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews, feature-vr-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use VrTabHelper to disable popups Disable media permission, bluetooth picker, javascript dialog, and file chooser when in VR mode. BUG=715604, 715609, 715613 patch from issue 2874623004 at patchset 220001 (http://crrev.com/2874623004#ps220001)

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -1 line)			Patch
M	chrome/browser/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/android/tab_web_contents_delegate_android.cc	View	5 chunks	+24 lines, -0 lines	0 comments	Download
M	chrome/browser/android/vr_shell/vr_shell.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download
A	chrome/browser/android/vr_shell/vr_tab_helper.h	View	1 chunk	+53 lines, -0 lines	0 comments	Download
A	chrome/browser/android/vr_shell/vr_tab_helper.cc	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_helpers.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download