Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: components/ntp_snippets/pref_names.cc

Issue 2875953003: [Soft fetches] Set-up different intervals for <Chrome started> events. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/pref_names.cc
diff --git a/components/ntp_snippets/pref_names.cc b/components/ntp_snippets/pref_names.cc
index fb5582a6725b6516ca97271710ca138aae67e138..87b5d6f10c5dd636c9814239f54620e954a83ae3 100644
--- a/components/ntp_snippets/pref_names.cc
+++ b/components/ntp_snippets/pref_names.cc
@@ -13,17 +13,21 @@ const char kRemoteSuggestionCategories[] = "ntp_snippets.remote_categories";
const char kSnippetLastFetchAttempt[] = "ntp_snippets.last_fetch_attempt";
-const char kSnippetSoftFetchingIntervalWifi[] =
- "ntp_snippets.soft_fetching_interval_wifi";
-
-const char kSnippetSoftFetchingIntervalFallback[] =
- "ntp_snippets.soft_fetching_interval_fallback";
-
+// For backwards compatibility, we do not rename
markusheintz_ 2017/05/15 09:35:47 I guess that comment can be moved to the correspon
jkrcal 2017/05/15 11:40:24 Done.
+// - the "soft_" prefs (should be "shown_");
+// - the "fetching_" prefs (should be "persistent_fetching_").
const char kSnippetPersistentFetchingIntervalWifi[] =
"ntp_snippets.fetching_interval_wifi";
-
const char kSnippetPersistentFetchingIntervalFallback[] =
"ntp_snippets.fetching_interval_fallback";
+const char kSnippetStartupFetchingIntervalWifi[] =
+ "ntp_snippets.startup_fetching_interval_wifi";
+const char kSnippetStartupFetchingIntervalFallback[] =
+ "ntp_snippets.startup_fetching_interval_fallback";
+const char kSnippetShownFetchingIntervalWifi[] =
+ "ntp_snippets.soft_fetching_interval_wifi";
+const char kSnippetShownFetchingIntervalFallback[] =
+ "ntp_snippets.soft_fetching_interval_fallback";
const char kSnippetFetcherRequestCount[] =
"ntp.request_throttler.suggestion_fetcher.count";

Powered by Google App Engine
This is Rietveld 408576698