third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp - Issue 2875933006: [LayoutNG] Misc fixes in ShapingLineBreaker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 2875933006: [LayoutNG] Misc fixes in ShapingLineBreaker (Closed)

Patch Set: clang build fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h » ('j') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

index 8ceb11b94d29ca01b7c18343d4d8d122891d495e..eed0a47fb84b6976b6bf75031df7ddc88eb7cc35 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

@@ -713,6 +713,8 @@ PassRefPtr<ShapeResult> HarfBuzzShaper::Shape(const Font* font,

if (start < segment_range.end && end > segment_range.start)

ShapeSegment(&range_data, segment_range, result.Get());

}

+ DCHECK_EQ(start, result->CharacterStartIndex());

+ DCHECK_EQ(end - start, result->NumCharacters());

return result.Release();

}