Inline noop willFoo/didFoo into SkCanvas.h.

Inline noop willFoo/didFoo into SkCanvas.h.

We've got our canvas subclasses all calling back up to these via
INHERITED, all noops.  That's fine but currently a little sad as they
can't be optimized away without link-time optimization, which we and
Chrome only do on Windows.  We actually make a call for each of these
today on non-Windows.

So, move the empty implementations into the header so those chaining
calls really can be optimized away.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14722

[mtklein, 2014-05-13 15:04:38]

As an alternative to crrev.com/280313002, let's fix all canvas subclasses.

[reed1, 2014-05-13 15:07:17]

I'm fine with either change. deferring to florin. lgtm

[f(malita), 2014-05-13 21:03:52]

LGTM

I like this better, thanks!

[mtklein, 2014-05-13 23:46:12]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-05-13 23:46:26]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/287593005/1

[commit-bot: I haz the power, 2014-05-13 23:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-13 23:53:13]

Failed to apply patch for include/core/SkCanvas.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: include/core/SkCanvas.h
  |diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h
  |index
70cfe287b85bb9226803dbdaf045db185eeb96a8..fa19176eeb99a90faff4c8965bdf2a52cee32674
100644
  |--- a/include/core/SkCanvas.h
  |+++ b/include/core/SkCanvas.h
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       include/core/SkCanvas.h
Index: include/core/SkCanvas.h
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h
index
70cfe287b85bb9226803dbdaf045db185eeb96a8..fa19176eeb99a90faff4c8965bdf2a52cee32674
100644
--- a/include/core/SkCanvas.h
+++ b/include/core/SkCanvas.h
@@ -1226,12 +1226,14 @@ protected:
         kFullLayer_SaveLayerStrategy,
         kNoLayer_SaveLayerStrategy
     };
-    virtual void willSave(SaveFlags);
-    virtual SaveLayerStrategy willSaveLayer(const SkRect*, const SkPaint*,
SaveFlags);
-    virtual void willRestore();
 
-    virtual void didConcat(const SkMatrix&);
-    virtual void didSetMatrix(const SkMatrix&);
+    virtual void willSave(SaveFlags) {}
+    virtual SaveLayerStrategy willSaveLayer(const SkRect*, const SkPaint*,
SaveFlags) {
+        return kFullLayer_SaveLayerStrategy;
+    }
+    virtual void willRestore() {}
+    virtual void didConcat(const SkMatrix&) {}
+    virtual void didSetMatrix(const SkMatrix&) {}
 
     virtual void onDrawDRRect(const SkRRect&, const SkRRect&, const SkPaint&);

[mtklein, 2014-05-14 13:13:29]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-05-14 13:13:35]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/287593005/1

[commit-bot: I haz the power, 2014-05-14 13:13:46]

Change committed as 14722