Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2875893002: [infra] Fix copy_tree.py to avoid extra rebuilding in Fuchsia (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
Bill Hesse, siva
CC:
reviews_dartlang.org, jamesr1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[infra] Fix copy_tree.py to avoid extra rebuilding in Fuchsia This CL computes the correct input and output in the copy_tree GN template by modifying tools/copy_tree.py to perform a dry-run that lists the files to be copied. Also, shutil.copytree uses shutil.copy2 to copy files and their metadata, but copying the metadata appears to confuse ninja dependency tracking. To do the dry run and to use shutil.copy instead of shutil.copy2, copy_tree.py now uses its own CopyTree function instead of shutil.copytree. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/5ec18fc68e993167ea54d5e9949b338622de19d6

Patch Set 1 #

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -299 lines) Patch
M sdk/BUILD.gn View 1 1 chunk +339 lines, -294 lines 0 comments Download
M tools/copy_tree.py View 3 chunks +52 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
This is split off from a CL I sent earlier today. Please take a look ...
3 years, 7 months ago (2017-05-11 06:08:22 UTC) #3
zra
3 years, 7 months ago (2017-05-11 14:53:45 UTC) #4
Bill Hesse
lgtm
3 years, 7 months ago (2017-05-11 15:04:12 UTC) #5
zra
3 years, 7 months ago (2017-05-11 16:46:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5ec18fc68e993167ea54d5e9949b338622de19d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698