Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 287583002: Revert of Fix a bug where if a crypto packet is spuriously retransmitted (Closed)

Created:
6 years, 7 months ago by ramant (doing other things)
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Revert of Fix a bug where if a crypto packet is spuriously retransmitted and thenneutered, it remains in missing_packets until the end of the connection. Reverted chromium cl: https://codereview.chromium.org/270213002/ Rollback of Merge internal change: 66262890. *** Reason for rollback *** This appears to have caused a major QUIC loadtest regression on internal server. Additionally, it's wrong in some other subtle ways, so rolling it back and trying a new approach. *** Original change description *** Fix a bug where if a crypto packet is spuriously retransmitted and then neutered, it remains in missing_packets until the end of the connection. *** Merge internal change: 66615668 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -33 lines) Patch
M net/quic/quic_connection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 7 months ago (2014-05-13 00:34:42 UTC) #1
Ryan Hamilton
6 years, 7 months ago (2014-05-13 00:42:00 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698