third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js - Issue 2875793004: Coverage: misc UI polish

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2875793004: Coverage: misc UI polish (Closed)

Patch Set: review comments, dropped some stray lines Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/coverage/coverageView.css ('k') | third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

index 08a9abfbe48f48d0a74663e3562401f5da1ec379..cdba648ce0c9c98d246f6a7fc0c2f69f8c83593c 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -666,8 +666,8 @@ Timeline.TimelinePanel = class extends UI.Panel {

this._landingPage.contentElement.classList.add('timeline-landing-page', 'fill');

var centered = this._landingPage.contentElement.createChild('div');

- var recordButton = UI.Toolbar.createActionButton(this._toggleRecordAction).element;

- var reloadButton = UI.Toolbar.createActionButtonForId('main.reload').element;

+ var recordButton = UI.createInlineButton(UI.Toolbar.createActionButton(this._toggleRecordAction));

+ var reloadButton = UI.createInlineButton(UI.Toolbar.createActionButtonForId('main.reload'));

centered.createChild('p').appendChild(UI.formatLocalized(

'Click the record button %s or hit %s to capture a new recording.\n' +