Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2875793004: Coverage: misc UI polish (Closed)
Patch Set: review comments, dropped some stray lines Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 659
660 var recordKey = 660 var recordKey =
661 encloseWithTag('b', UI.shortcutRegistry.shortcutDescriptorsForAction('ti meline.toggle-recording')[0].name); 661 encloseWithTag('b', UI.shortcutRegistry.shortcutDescriptorsForAction('ti meline.toggle-recording')[0].name);
662 var reloadKey = encloseWithTag('b', UI.shortcutRegistry.shortcutDescriptorsF orAction('main.reload')[0].name); 662 var reloadKey = encloseWithTag('b', UI.shortcutRegistry.shortcutDescriptorsF orAction('main.reload')[0].name);
663 var navigateNode = encloseWithTag('b', Common.UIString('WASD')); 663 var navigateNode = encloseWithTag('b', Common.UIString('WASD'));
664 664
665 this._landingPage = new UI.VBox(); 665 this._landingPage = new UI.VBox();
666 this._landingPage.contentElement.classList.add('timeline-landing-page', 'fil l'); 666 this._landingPage.contentElement.classList.add('timeline-landing-page', 'fil l');
667 var centered = this._landingPage.contentElement.createChild('div'); 667 var centered = this._landingPage.contentElement.createChild('div');
668 668
669 var recordButton = UI.Toolbar.createActionButton(this._toggleRecordAction).e lement; 669 var recordButton = UI.createInlineButton(UI.Toolbar.createActionButton(this. _toggleRecordAction));
670 var reloadButton = UI.Toolbar.createActionButtonForId('main.reload').element ; 670 var reloadButton = UI.createInlineButton(UI.Toolbar.createActionButtonForId( 'main.reload'));
671 671
672 centered.createChild('p').appendChild(UI.formatLocalized( 672 centered.createChild('p').appendChild(UI.formatLocalized(
673 'Click the record button %s or hit %s to capture a new recording.\n' + 673 'Click the record button %s or hit %s to capture a new recording.\n' +
674 'Click the reload button %s or hit %s to record and evaluate the page lo ad.', 674 'Click the reload button %s or hit %s to record and evaluate the page lo ad.',
675 [recordButton, recordKey, reloadButton, reloadKey])); 675 [recordButton, recordKey, reloadButton, reloadKey]));
676 676
677 centered.createChild('p').appendChild(UI.formatLocalized( 677 centered.createChild('p').appendChild(UI.formatLocalized(
678 'After recording, select an area of interest in the overview by dragging .\n' + 678 'After recording, select an area of interest in the overview by dragging .\n' +
679 'Then, zoom and pan the timeline with the mousewheel or %s keys.\n%s', 679 'Then, zoom and pan the timeline with the mousewheel or %s keys.\n%s',
680 [navigateNode, learnMoreNode])); 680 [navigateNode, learnMoreNode]));
(...skipping 624 matching lines...) Expand 10 before | Expand all | Expand 10 after
1305 return true; 1305 return true;
1306 case 'timeline.jump-to-next-frame': 1306 case 'timeline.jump-to-next-frame':
1307 panel._jumpToFrame(1); 1307 panel._jumpToFrame(1);
1308 return true; 1308 return true;
1309 } 1309 }
1310 return false; 1310 return false;
1311 } 1311 }
1312 }; 1312 };
1313 1313
1314 Timeline.TimelinePanel._traceProviderSettingSymbol = Symbol('traceProviderSettin g'); 1314 Timeline.TimelinePanel._traceProviderSettingSymbol = Symbol('traceProviderSettin g');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698