Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2875793002: Why this CL triggers an OilPan crash.
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 class WebSettingsImpl; 94 class WebSettingsImpl;
95 class WebViewScheduler; 95 class WebViewScheduler;
96 96
97 class WEB_EXPORT WebViewImpl final 97 class WEB_EXPORT WebViewImpl final
98 : NON_EXPORTED_BASE(public WebViewBase), 98 : NON_EXPORTED_BASE(public WebViewBase),
99 NON_EXPORTED_BASE(public WebGestureCurveTarget), 99 NON_EXPORTED_BASE(public WebGestureCurveTarget),
100 public PageWidgetEventHandler, 100 public PageWidgetEventHandler,
101 public WebScheduler::InterventionReporter, 101 public WebScheduler::InterventionReporter,
102 public WebViewScheduler::WebViewSchedulerSettings { 102 public WebViewScheduler::WebViewSchedulerSettings {
103 public: 103 public:
104 static WebViewBase* Create(WebViewClient*, WebPageVisibilityState); 104 static WebViewBase* Create(WebViewClient*,
105 WebPageVisibilityState,
106 int browsing_instance_id);
105 107
106 // WebWidget methods: 108 // WebWidget methods:
107 void Close() override; 109 void Close() override;
108 WebSize Size() override; 110 WebSize Size() override;
109 void Resize(const WebSize&) override; 111 void Resize(const WebSize&) override;
110 void ResizeVisualViewport(const WebSize&) override; 112 void ResizeVisualViewport(const WebSize&) override;
111 void DidEnterFullscreen() override; 113 void DidEnterFullscreen() override;
112 void DidExitFullscreen() override; 114 void DidExitFullscreen() override;
113 115
114 void SetSuppressFrameRequestsWorkaroundFor704763Only(bool) override; 116 void SetSuppressFrameRequestsWorkaroundFor704763Only(bool) override;
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
534 // TODO(lfg): Remove once WebViewFrameWidget is deleted. 536 // TODO(lfg): Remove once WebViewFrameWidget is deleted.
535 void ScheduleAnimationForWidget() override; 537 void ScheduleAnimationForWidget() override;
536 bool GetCompositionCharacterBounds(WebVector<WebRect>&) override; 538 bool GetCompositionCharacterBounds(WebVector<WebRect>&) override;
537 539
538 void UpdateBaseBackgroundColor(); 540 void UpdateBaseBackgroundColor();
539 541
540 friend class WebView; // So WebView::Create can call our constructor 542 friend class WebView; // So WebView::Create can call our constructor
541 friend class WebViewFrameWidget; 543 friend class WebViewFrameWidget;
542 friend class WTF::RefCounted<WebViewImpl>; 544 friend class WTF::RefCounted<WebViewImpl>;
543 545
544 explicit WebViewImpl(WebViewClient*, WebPageVisibilityState); 546 explicit WebViewImpl(WebViewClient*,
547 WebPageVisibilityState,
548 int browsing_instance_id);
545 ~WebViewImpl() override; 549 ~WebViewImpl() override;
546 550
547 void HideSelectPopup(); 551 void HideSelectPopup();
548 552
549 HitTestResult HitTestResultForRootFramePos(const IntPoint&); 553 HitTestResult HitTestResultForRootFramePos(const IntPoint&);
550 HitTestResult HitTestResultForViewportPos(const IntPoint&); 554 HitTestResult HitTestResultForViewportPos(const IntPoint&);
551 555
552 void ConfigureAutoResizeMode(); 556 void ConfigureAutoResizeMode();
553 557
554 void InitializeLayerTreeView(); 558 void InitializeLayerTreeView();
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
746 Persistent<ResizeViewportAnchor> resize_viewport_anchor_; 750 Persistent<ResizeViewportAnchor> resize_viewport_anchor_;
747 }; 751 };
748 752
749 // We have no ways to check if the specified WebView is an instance of 753 // We have no ways to check if the specified WebView is an instance of
750 // WebViewImpl because WebViewImpl is the only implementation of WebView. 754 // WebViewImpl because WebViewImpl is the only implementation of WebView.
751 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 755 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
752 756
753 } // namespace blink 757 } // namespace blink
754 758
755 #endif 759 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698