Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: third_party/WebKit/Source/core/page/FrameTree.cpp

Issue 2875793002: Why this CL triggers an OilPan crash.
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/core/page/Page.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 return nullptr; 179 return nullptr;
180 180
181 for (Frame* frame = page->MainFrame(); frame; 181 for (Frame* frame = page->MainFrame(); frame;
182 frame = frame->Tree().TraverseNext()) { 182 frame = frame->Tree().TraverseNext()) {
183 if (frame->Tree().GetName() == name) 183 if (frame->Tree().GetName() == name)
184 return frame; 184 return frame;
185 } 185 }
186 186
187 // Search the entire tree of each of the other pages in this namespace. 187 // Search the entire tree of each of the other pages in this namespace.
188 // FIXME: Is random order OK? 188 // FIXME: Is random order OK?
189 for (const Page* other_page : Page::OrdinaryPages()) { 189 for (const Page* other_page : page->RelatedPages()) {
190 if (other_page == page || other_page->IsClosing()) 190 if (other_page == page || other_page->IsClosing())
191 continue; 191 continue;
192 for (Frame* frame = other_page->MainFrame(); frame; 192 for (Frame* frame = other_page->MainFrame(); frame;
193 frame = frame->Tree().TraverseNext()) { 193 frame = frame->Tree().TraverseNext()) {
194 if (frame->Tree().GetName() == name) 194 if (frame->Tree().GetName() == name)
195 return frame; 195 return frame;
196 } 196 }
197 } 197 }
198 198
199 return nullptr; 199 return nullptr;
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 void showFrameTree(const blink::Frame* frame) { 296 void showFrameTree(const blink::Frame* frame) {
297 if (!frame) { 297 if (!frame) {
298 printf("Null input frame\n"); 298 printf("Null input frame\n");
299 return; 299 return;
300 } 300 }
301 301
302 printFrames(&frame->Tree().Top(), frame, 0); 302 printFrames(&frame->Tree().Top(), frame, 0);
303 } 303 }
304 304
305 #endif 305 #endif
OLDNEW
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/core/page/Page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698