Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 2875793002: Why this CL triggers an OilPan crash.
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 751 matching lines...) Expand 10 before | Expand all | Expand 10 after
762 762
763 // Bookkeeping to suppress redundant scroll and focus requests for an already 763 // Bookkeeping to suppress redundant scroll and focus requests for an already
764 // scrolled and focused editable node. 764 // scrolled and focused editable node.
765 bool has_scrolled_focused_editable_node_into_rect_; 765 bool has_scrolled_focused_editable_node_into_rect_;
766 gfx::Rect rect_for_scrolled_focused_editable_node_; 766 gfx::Rect rect_for_scrolled_focused_editable_node_;
767 767
768 // Used to indicate the zoom level to be used during subframe loads, since 768 // Used to indicate the zoom level to be used during subframe loads, since
769 // they should match page zoom level. 769 // they should match page zoom level.
770 double page_zoom_level_; 770 double page_zoom_level_;
771 771
772 // Id of a related set of browsing contexts that this view belongs to.
773 int browsing_instance_id_;
774
772 // Helper objects ------------------------------------------------------------ 775 // Helper objects ------------------------------------------------------------
773 776
774 RenderFrameImpl* main_render_frame_; 777 RenderFrameImpl* main_render_frame_;
775 778
776 // Note: RenderViewImpl is pulling double duty: it's the RenderWidget for the 779 // Note: RenderViewImpl is pulling double duty: it's the RenderWidget for the
777 // "view", but it's also the RenderWidget for the main frame. 780 // "view", but it's also the RenderWidget for the main frame.
778 blink::WebFrameWidget* frame_widget_; 781 blink::WebFrameWidget* frame_widget_;
779 782
780 // The next group of objects all implement RenderViewObserver, so are deleted 783 // The next group of objects all implement RenderViewObserver, so are deleted
781 // along with the RenderView automatically. This is why we just store 784 // along with the RenderView automatically. This is why we just store
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
829 // --------------------------------------------------------------------------- 832 // ---------------------------------------------------------------------------
830 833
831 base::WeakPtrFactory<RenderViewImpl> weak_ptr_factory_; 834 base::WeakPtrFactory<RenderViewImpl> weak_ptr_factory_;
832 835
833 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 836 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
834 }; 837 };
835 838
836 } // namespace content 839 } // namespace content
837 840
838 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 841 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698