Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2875773003: Roll 50: Updated for push to origin/master. (Closed)

Created:
3 years, 7 months ago by terry
Modified:
3 years, 7 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Roll 50: Updated to latest #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11240 lines, -7569 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M build/sanitizers/tsan_suppressions.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 220 chunks +2864 lines, -1986 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 15 chunks +385 lines, -1000 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 240 chunks +3593 lines, -1782 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/js/dartium/cached_patches.dart View 1 48 chunks +610 lines, -385 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 20 chunks +204 lines, -1564 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 9 chunks +97 lines, -37 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 46 chunks +647 lines, -106 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 30 chunks +72 lines, -38 lines 0 comments Download
M tests/html/events_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/html.status View 1 2 chunks +1 line, -5 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tools/bots/bot_utils.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tools/dartium/archive.py View 1 1 chunk +4 lines, -3 lines 0 comments Download
M tools/dartium/build.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dartium/buildbot_annotated_steps.py View 1 1 chunk +6 lines, -7 lines 0 comments Download
M tools/dartium/generate_patches.sh View 1 1 chunk +19 lines, -5 lines 0 comments Download
M tools/dartium/test.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 4 chunks +10 lines, -16 lines 0 comments Download
M tools/deps/dartium.deps/DEPS.chromium View 1 16 chunks +152 lines, -107 lines 0 comments Download
M tools/dom/dom.json View 1 114 chunks +1764 lines, -156 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 2 chunks +30 lines, -0 lines 0 comments Download
M tools/dom/new_scripts/dart_utilities.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/scripts/css_code_generator.py View 1 1 chunk +1 line, -5 lines 0 comments Download
M tools/dom/scripts/generate_blink_file.py View 1 7 chunks +46 lines, -8 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 6 chunks +23 lines, -5 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 3 chunks +8 lines, -7 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 12 chunks +97 lines, -20 lines 0 comments Download
M tools/dom/scripts/idlnode.py View 1 9 chunks +197 lines, -90 lines 0 comments Download
M tools/dom/scripts/idlsync.py View 1 2 chunks +280 lines, -195 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 chunks +6 lines, -1 line 0 comments Download
M tools/dom/src/dart2js_KeyEvent.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tools/dom/src/dart2js_WrappedEvent.dart View 1 1 chunk +9 lines, -1 line 0 comments Download
M tools/dom/src/dartium_CssClassSet.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/src/dartium_KeyEvent.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/src/dartium_WrappedEvent.dart View 1 1 chunk +9 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +10 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 1 chunk +10 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 1 chunk +1 line, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DOMException.darttemplate View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 chunks +11 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 2 chunks +6 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HashChangeEvent.darttemplate View 1 1 chunk +3 lines, -7 lines 0 comments Download
M tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate View 1 1 chunk +12 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 3 chunks +7 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_TouchEvent.darttemplate View 1 1 chunk +8 lines, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 1 chunk +4 lines, -0 lines 1 comment Download
M tools/testing/dart/test_suite.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/utils.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
terry
Committed patchset #2 (id:10001) manually as f27144d7b5b7f8063eb3ac0d90c23c87a40e7163 (presubmit successful).
3 years, 7 months ago (2017-05-11 01:17:05 UTC) #2
Jacob
3 years, 7 months ago (2017-05-11 04:22:07 UTC) #3
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/2875773003/diff/10001/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2875773003/diff/10001/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:2108: // TODO(terry): Needed for roll 50?
is this really needed?

Powered by Google App Engine
This is Rietveld 408576698