ui/aura/mus/mus_context_factory.cc - Issue 2875753002: Implement aura::WindowPortMus::CreateCompositorFrameSink()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/mus/mus_context_factory.cc

Issue 2875753002: Implement aura::WindowPortMus::CreateCompositorFrameSink() (Closed)

Patch Set: Address review issues. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/mus/mus_context_factory.cc

diff --git a/ui/aura/mus/mus_context_factory.cc b/ui/aura/mus/mus_context_factory.cc

index 443f970d7baa0a7d4788c4b87bacf480cc32a548..97cd05ef350eb66a96ac66bee0b6abc6fe3a490b 100644

--- a/ui/aura/mus/mus_context_factory.cc

+++ b/ui/aura/mus/mus_context_factory.cc

@@ -39,7 +39,7 @@ void MusContextFactory::OnEstablishedGpuChannel(

WindowPortMus* window_port = WindowPortMus::Get(host->window());

DCHECK(window_port);

std::unique_ptr<cc::CompositorFrameSink> compositor_frame_sink =

- window_port->RequestCompositorFrameSink(

+ window_port->CreateCompositorFrameSinkWithContextAndBufferManager(

Fady Samuel 2017/05/30 18:36:41 This is a really long name? Can we just keep the n

Peng 2017/05/31 20:12:25 Done.

gpu_->CreateContextProvider(std::move(gpu_channel)),

gpu_->gpu_memory_buffer_manager());

compositor->SetCompositorFrameSink(std::move(compositor_frame_sink));