Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: components/exo/surface.cc

Issue 2875753002: Implement aura::WindowPortMus::CreateCompositorFrameSink() (Closed)
Patch Set: Address review issues. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/surface.cc
diff --git a/components/exo/surface.cc b/components/exo/surface.cc
index 301b8d96cdf52b2cbd112b2769a41e2383775d1d..f5d3b2f84d255bc727a57bd5f115afca9b9c4aff 100644
--- a/components/exo/surface.cc
+++ b/components/exo/surface.cc
@@ -167,10 +167,6 @@ class CustomWindowTargeter : public aura::WindowTargeter {
////////////////////////////////////////////////////////////////////////////////
// Surface, public:
-// TODO(fsamuel): exo should not use context_factory_private. Instead, we should
-// request a CompositorFrameSink from the aura::Window. Setting up the
-// BeginFrame hierarchy should be an internal implementation detail of aura or
-// mus in aura-mus.
Surface::Surface() : window_(new aura::Window(new CustomWindowDelegate(this))) {
window_->SetType(aura::client::WINDOW_TYPE_CONTROL);
window_->SetName("ExoSurface");
@@ -790,6 +786,7 @@ void Surface::UpdateSurface(bool full_damage) {
}
content_size_ = layer_size;
+ window_->SetBounds(gfx::Rect(window_->bounds().origin(), content_size_));
Fady Samuel 2017/05/30 18:36:41 Why?
Peng 2017/05/30 19:46:28 ClientSurfaceEmbedder will read window's size and
// TODO(jbauman): Figure out how this interacts with the pixel size of
// CopyOutputRequests on the layer.
gfx::Size contents_surface_size = layer_size;
« no previous file with comments | « no previous file | components/viz/client/client_compositor_frame_sink.h » ('j') | services/ui/ws/window_server.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698