Index: tools/testing/dart/test_runner.dart |
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart |
index a05382368da40955578afde0031cda7f831fa209..52280c0158229c9153748f1aec42603e3a02a748 100644 |
--- a/tools/testing/dart/test_runner.dart |
+++ b/tools/testing/dart/test_runner.dart |
@@ -1043,7 +1043,8 @@ class BrowserCommandOutputImpl extends CommandOutputImpl { |
// See: http://dartbug.com/15139. |
static int WHITELISTED_CONTENTSHELL_EXITCODE = -1073740022; |
static bool isWindows = io.Platform.operatingSystem == 'windows'; |
- static bool _failedBecauseOfFlakyInfrastructure(List<int> stderrBytes) { |
+ static bool _failedBecauseOfFlakyInfrastructure( |
+ Command command, bool timedOut, List<int> stderrBytes) { |
// If the browser test failed, it may have been because content shell |
// and the virtual framebuffer X server didn't hook up, or it crashed with |
// a core dump. Sometimes content shell crashes after it has set the stdout |
@@ -1052,7 +1053,7 @@ class BrowserCommandOutputImpl extends CommandOutputImpl { |
var zygoteCrash = |
new RegExp(r"ERROR:zygote_linux\.cc\(\d+\)] write: Broken pipe"); |
var stderr = decodeUtf8(stderrBytes); |
- // TODO(whesse): Issue: 7564 |
+ // TODO(7564): See http://dartbug.com/7564 |
// This may not be happening anymore. Test by removing this suppression. |
if (stderr.contains(MESSAGE_CANNOT_OPEN_DISPLAY) || |
stderr.contains(MESSAGE_FAILED_TO_RUN_COMMAND)) { |
@@ -1060,12 +1061,19 @@ class BrowserCommandOutputImpl extends CommandOutputImpl { |
"Warning: Failure because of missing XDisplay. Test ignored"); |
return true; |
} |
- // Issue 26739 |
+ // TODO(26739): See http://dartbug.com/26739 |
if (zygoteCrash.hasMatch(stderr)) { |
DebugLogger.warning("Warning: Failure because of content_shell " |
"zygote crash. Test ignored"); |
return true; |
} |
+ // TODO(28955): See http://dartbug.com/28955 |
+ if (timedOut && |
+ command is BrowserTestCommand && |
+ command.browser == "ie11") { |
Siggi Cherem (dart-lang)
2017/05/10 15:05:45
Since we have rarely seen ie11 timeout on win8, sh
|
+ DebugLogger.warning("Timeout of ie11 on test page ${command.url}"); |
+ return; |
karlklose
2017/05/11 11:25:41
This should return a boolean value.
|
+ } |
return false; |
} |
@@ -1073,7 +1081,8 @@ class BrowserCommandOutputImpl extends CommandOutputImpl { |
BrowserCommandOutputImpl( |
command, exitCode, timedOut, stdout, stderr, time, compilationSkipped) |
- : _infraFailure = _failedBecauseOfFlakyInfrastructure(stderr), |
+ : _infraFailure = |
+ _failedBecauseOfFlakyInfrastructure(command, timedOut, stderr), |
super(command, exitCode, timedOut, stdout, stderr, time, |
compilationSkipped, 0); |