Report IE11 timeouts in debug log, not as failing tests.

Report IE11 timeouts in debug log, not as failing tests.

BUG=https://github.com/dart-lang/sdk/issues/28955
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/d6ca1a5defcbe3834d08a67511abc23bb902f073

[Bill Hesse, 2017-05-10 14:32:18]

whesse@google.com changed reviewers:
+ efortuna@google.com, kmillikin@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-10 15:05:45]

lgtm, thank you Bill.

https://codereview.chromium.org/2875683002/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2875683002/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:1073: command.browser == "ie11") {
Since we have rarely seen ie11 timeout on win8, should we only do this special
case on win7?

[Bill Hesse, 2017-05-10 15:18:59]

On 2017/05/10 15:05:45, Siggi Cherem (dart-lang) wrote:
> lgtm, thank you Bill.
> 
>
https://codereview.chromium.org/2875683002/diff/1/tools/testing/dart/test_run...
> File tools/testing/dart/test_runner.dart (right):
> 
>
https://codereview.chromium.org/2875683002/diff/1/tools/testing/dart/test_run...
> tools/testing/dart/test_runner.dart:1073: command.browser == "ie11") {
> Since we have rarely seen ie11 timeout on win8, should we only do this special
> case on win7?

If we did see a timeout on win8, we would do the same thing we are currently
doing on win7: nothing.
Only data mining of the timeouts, to detect problem tests, will be effective in
finding a specific problem test,
and we will run that on win8 as well as win7, so there is no reason not to treat
them the same.

[Bill Hesse, 2017-05-11 09:18:47]

Description was changed from

==========
Report IE11 timeouts in debug log, not as failing tests.

BUG=https://github.com/dart-lang/sdk/issues/28955
==========

to

==========
Report IE11 timeouts in debug log, not as failing tests.

BUG=https://github.com/dart-lang/sdk/issues/28955
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d6ca1a5defcbe3834d08a67511abc23bb902f073
==========

[Bill Hesse, 2017-05-11 09:18:48]

Committed patchset #1 (id:1) manually as
d6ca1a5defcbe3834d08a67511abc23bb902f073 (presubmit successful).

[karlklose, 2017-05-11 11:25:40]

karlklose@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-05-11 11:25:41]

https://codereview.chromium.org/2875683002/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2875683002/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:1075: return;
This should return a boolean value.

[Bill Hesse, 2017-05-11 11:47:49]

On 2017/05/11 11:25:41, karlklose wrote:
>
https://codereview.chromium.org/2875683002/diff/1/tools/testing/dart/test_run...
> File tools/testing/dart/test_runner.dart (right):
> 
>
https://codereview.chromium.org/2875683002/diff/1/tools/testing/dart/test_run...
> tools/testing/dart/test_runner.dart:1075: return;
> This should return a boolean value.

Fixed in https://codereview.chromium.org/2874193002/
Committed as 
https://github.com/dart-lang/sdk/commit/bff560292ced495622771b668a0689167b2b4f81

[Siggi Cherem (dart-lang), 2017-05-11 18:00:30]

On 2017/05/10 15:18:59, Bill Hesse wrote:
> On 2017/05/10 15:05:45, Siggi Cherem (dart-lang) wrote:
> > lgtm, thank you Bill.
> > 
> >
>
https://codereview.chromium.org/2875683002/diff/1/tools/testing/dart/test_run...
> > File tools/testing/dart/test_runner.dart (right):
> > 
> >
>
https://codereview.chromium.org/2875683002/diff/1/tools/testing/dart/test_run...
> > tools/testing/dart/test_runner.dart:1073: command.browser == "ie11") {
> > Since we have rarely seen ie11 timeout on win8, should we only do this
special
> > case on win7?
> 
> If we did see a timeout on win8, we would do the same thing we are currently
> doing on win7: nothing.
> Only data mining of the timeouts, to detect problem tests, will be effective
in
> finding a specific problem test,
> and we will run that on win8 as well as win7, so there is no reason not to
treat
> them the same.

Fair enough