Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: services/resource_coordinator/memory/coordinator/coordinator_impl.h

Issue 2875673003: [Memory-UMA] Add ProcessMap, an Identity to Pid map (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/memory/coordinator/coordinator_impl.h
diff --git a/services/resource_coordinator/memory/coordinator/coordinator_impl.h b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
index 096847b0f9aca14eb9cda21ab6d67f99d1cca09f..94f2d93134f2e74176b9ae855e5ad2d910019888 100644
--- a/services/resource_coordinator/memory/coordinator/coordinator_impl.h
+++ b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
@@ -14,6 +14,7 @@
#include "base/trace_event/memory_dump_request_args.h"
#include "mojo/public/cpp/bindings/binding.h"
#include "mojo/public/cpp/bindings/binding_set.h"
+#include "services/resource_coordinator/memory/coordinator/process_map.h"
#include "services/resource_coordinator/public/cpp/memory/coordinator.h"
#include "services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom.h"
@@ -50,6 +51,10 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
std::vector<mojom::ProcessMemoryDumpPtr> process_memory_dumps;
};
+ typedef std::pair<mojom::ProcessLocalDumpManagerPtr,
+ service_manager::Identity>
+ ProcessLocalDumpManagerEntry;
+
~CoordinatorImpl() override;
// mojom::Coordinator
@@ -76,11 +81,12 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
void PerformNextQueuedGlobalMemoryDump();
void FinalizeGlobalMemoryDumpIfAllManagersReplied();
+ void InitProcessMap();
- mojo::BindingSet<mojom::Coordinator> bindings_;
+ mojo::BindingSet<mojom::Coordinator, service_manager::Identity> bindings_;
// Registered ProcessLocalDumpManagers.
- std::map<mojom::ProcessLocalDumpManager*, mojom::ProcessLocalDumpManagerPtr>
+ std::map<mojom::ProcessLocalDumpManager*, ProcessLocalDumpManagerEntry>
process_managers_;
// Pending process managers for RequestGlobalMemoryDump.
@@ -92,6 +98,8 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
base::ThreadChecker thread_checker_;
+ std::unique_ptr<ProcessMap> process_map_;
+
DISALLOW_COPY_AND_ASSIGN(CoordinatorImpl);
};
« no previous file with comments | « services/resource_coordinator/BUILD.gn ('k') | services/resource_coordinator/memory/coordinator/coordinator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698